On Mon, Jul 28, 2008 at 9:32 AM, Freeman Fang <[EMAIL PROTECTED]> wrote: > Hi Guillaume, > > How about we just exclude file with extensor like "txt" "xml" "properties" > to avoid the exception like > java.util.zip.ZipException: error in opening zip file?
Yeah, I think it would be safer and would still avoid those exceptions in the log. > Or leave the exception info alone in the log since it's DEBUG level logs? > > Regards > Freeman > > Guillaume Nodet wrote: >> >> Not sure if this patch is the right one. What if someone wants to >> deploy a war or another kind of extensions. These could already be >> OSGi bundles, so I don't think we should ignore them for the default >> deployer. >> >> On Mon, Jul 28, 2008 at 6:16 AM, <[EMAIL PROTECTED]> wrote: >> >>> >>> Author: ffang >>> Date: Sun Jul 27 21:16:35 2008 >>> New Revision: 680252 >>> >>> URL: http://svn.apache.org/viewvc?rev=680252&view=rev >>> Log: >>> [SMX4-76]error in opening zip file when start smx4 >>> >>> Modified: >>> >>> servicemix/smx4/kernel/trunk/filemonitor/src/main/java/org/apache/servicemix/kernel/filemonitor/FileMonitor.java >>> >>> Modified: >>> servicemix/smx4/kernel/trunk/filemonitor/src/main/java/org/apache/servicemix/kernel/filemonitor/FileMonitor.java >>> URL: >>> http://svn.apache.org/viewvc/servicemix/smx4/kernel/trunk/filemonitor/src/main/java/org/apache/servicemix/kernel/filemonitor/FileMonitor.java?rev=680252&r1=680251&r2=680252&view=diff >>> >>> ============================================================================== >>> --- >>> servicemix/smx4/kernel/trunk/filemonitor/src/main/java/org/apache/servicemix/kernel/filemonitor/FileMonitor.java >>> (original) >>> +++ >>> servicemix/smx4/kernel/trunk/filemonitor/src/main/java/org/apache/servicemix/kernel/filemonitor/FileMonitor.java >>> Sun Jul 27 21:16:35 2008 >>> @@ -342,6 +342,10 @@ >>> JarFile jar = null; >>> try { >>> // Handle OSGi bundles with the default deployer >>> + if (!file.getName().endsWith("zip") && >>> !file.getName().endsWith("jar")) { >>> + // that's file type which is not supported as bundle >>> + return null; >>> + } >>> jar = new JarFile(file); >>> Manifest m = jar.getManifest(); >>> if (m.getMainAttributes().getValue(new >>> Attributes.Name("Bundle-SymbolicName")) != null && >>> >>> >>> >>> >> >> >> >> > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/
