[ 
https://issues.apache.org/activemq/browse/SM-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45737#action_45737
 ] 

Guillaume Nodet commented on SM-1576:
-------------------------------------

Note that the following commits do not enable waiting for all exchanges to be 
processed when deactivating the endpoint

Sending        servicemix-common/pom.xml
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/AbstractDeployer.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/AsyncBaseLifeCycle.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/BaseComponent.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/BaseServiceUnitManager.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/DefaultBootstrap.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/DefaultComponent.java
Adding         
servicemix-common/src/main/java/org/apache/servicemix/common/DefaultServiceUnit.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/Endpoint.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/EndpointDeliveryChannel.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/ExchangeProcessor.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/Registry.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/ServiceMixComponent.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/ServiceUnit.java
Adding         
servicemix-common/src/main/java/org/apache/servicemix/common/endpoints/AbstractEndpoint.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/endpoints/ConsumerEndpoint.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/endpoints/ProviderEndpoint.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/endpoints/SimpleEndpoint.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/osgi/EndpointTracker.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/wsdl1/AbstractWsdl1Deployer.java
Sending        
servicemix-common/src/main/java/org/apache/servicemix/common/xbean/XBeanServiceUnit.java
Sending        
servicemix-common/src/test/java/org/apache/servicemix/common/TransactionsTest.java
Sending        
servicemix-common/src/test/java/org/apache/servicemix/common/xbean/XBeanEndpoint.java
Sending        
servicemix-soap/src/main/java/org/apache/servicemix/soap/SoapEndpoint.java
Adding         
servicemix-soap/src/main/java/org/apache/servicemix/soap/SoapExchangeProcessor.java
Transmitting file data .........................
Committed revision 695836.
Sending        src/main/java/org/apache/servicemix/cxfbc/CxfBcConsumer.java
Sending        
src/test/java/org/apache/servicemix/cxfbc/provider/CxfBCSEProviderSystemTest.java
Sending        src/test/resources/org/apache/servicemix/cxfbc/xbean.xml
Sending        
src/test/resources/org/apache/servicemix/cxfbc/xbean_without_jbi_wrapper.xml
Transmitting file data ....
Committed revision 695837.
Sending        src/main/java/org/apache/servicemix/file/FileComponent.java
Transmitting file data .
Committed revision 695838.
Sending        src/main/java/org/apache/servicemix/ftp/FtpComponent.java
Transmitting file data .
Committed revision 695839.
Sending        src/main/java/org/apache/servicemix/http/HttpComponent.java
Sending        src/main/java/org/apache/servicemix/http/HttpEndpoint.java
Sending        src/main/java/org/apache/servicemix/http/HttpWsdl1Deployer.java
Sending        
src/main/java/org/apache/servicemix/http/endpoints/HttpConsumerEndpoint.java
Sending        
src/main/java/org/apache/servicemix/http/processors/ConsumerProcessor.java
Sending        
src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java
Sending        src/test/java/org/apache/servicemix/http/HttpAddressingTest.java
Sending        src/test/java/org/apache/servicemix/http/HttpConsumerTest.java
Sending        src/test/java/org/apache/servicemix/http/HttpProviderTest.java
Sending        
src/test/java/org/apache/servicemix/http/HttpXBeanDeployerTest.java
Sending        
src/test/java/org/apache/servicemix/http/ProviderEndpointTest.java
Transmitting file data ...........
Committed revision 695841.
Sending        src/main/java/org/apache/servicemix/jms/AbstractJmsProcessor.java
Sending        src/main/java/org/apache/servicemix/jms/JmsComponent.java
Sending        src/main/java/org/apache/servicemix/jms/JmsEndpoint.java
Sending        src/main/java/org/apache/servicemix/jms/JmsWsdl1Deployer.java
Sending        
src/main/java/org/apache/servicemix/jms/endpoints/AbstractConsumerEndpoint.java
Sending        
src/main/java/org/apache/servicemix/jms/endpoints/JmsConsumerEndpoint.java
Sending        
src/main/java/org/apache/servicemix/jms/endpoints/JmsProviderEndpoint.java
Sending        
src/main/java/org/apache/servicemix/jms/multiplexing/MultiplexingConsumerProcessor.java
Sending        
src/main/java/org/apache/servicemix/jms/multiplexing/MultiplexingProviderProcessor.java
Sending        
src/main/java/org/apache/servicemix/jms/standard/StandardConsumerProcessor.java
Sending        
src/main/java/org/apache/servicemix/jms/standard/StandardProviderProcessor.java
Sending        src/test/java/org/apache/servicemix/jms/JMSComponentTest.java
Sending        src/test/java/org/apache/servicemix/jms/JmsSpringTest.java
Sending        src/test/java/org/apache/servicemix/jms/JmsXBeanDeployerTest.java
Transmitting file data ..............
Committed revision 695842.
Sending        pom.xml
Sending        src/main/java/org/apache/servicemix/truezip/TrueZipComponent.java
Transmitting file data ..
Committed revision 695843.
Sending        src/main/java/org/apache/servicemix/xmpp/XMPPComponent.java
Transmitting file data .
Committed revision 695845.
Sending        src/main/java/org/apache/servicemix/bean/BeanComponent.java
Sending        src/test/java/org/apache/servicemix/bean/ConsumerBeanTest.java
Sending        
src/test/java/org/apache/servicemix/bean/ConsumerListenerTest.java
Sending        
src/test/java/org/apache/servicemix/bean/beans/ConsumerListener.java
Sending        src/test/resources/log4j.properties
Transmitting file data .....
Committed revision 695846.
Sending        src/main/java/org/apache/servicemix/camel/CamelJbiComponent.java
Transmitting file data .
Committed revision 695847.
Sending        src/test/java/org/apache/servicemix/cxfse/GreeterImpl.java
Sending        src/test/resources/log4j.properties
Transmitting file data ..
Committed revision 695848.
Sending        src/main/java/org/apache/servicemix/drools/DroolsEndpoint.java
Transmitting file data .
Committed revision 695849.
Sending        src/test/java/org/apache/servicemix/eip/DeploymentTest.java
Transmitting file data .
Committed revision 695850.
Sending        
src/test/java/org/apache/servicemix/jsr181/Jsr181ComplexPojoTest.java
Sending        
src/test/java/org/apache/servicemix/jsr181/Jsr181ComponentTest.java
Sending        
src/test/java/org/apache/servicemix/jsr181/Jsr181SpringProxyTest.java
Sending        src/test/java/test/TestEndpoint.java
Transmitting file data ....
Committed revision 695851.
Sending        
src/test/java/org/apache/servicemix/osworkflow/OSWorkflowFailureTest.java
Sending        
src/test/java/org/apache/servicemix/osworkflow/OSWorkflowSucessTest.java
Transmitting file data ..
Committed revision 695852.
Sending        src/test/java/org/apache/servicemix/saxon/SaxonComponentTest.java
Transmitting file data .
Committed revision 695853.
Sending        
src/main/java/org/apache/servicemix/wsn/client/AbstractWSAClient.java
Sending        
src/main/java/org/apache/servicemix/wsn/component/WSNComponent.java
Sending        
src/main/java/org/apache/servicemix/wsn/component/WSNDeployableEndpoint.java
Sending        
src/main/java/org/apache/servicemix/wsn/component/WSNEndpoint.java
Sending        
src/main/java/org/apache/servicemix/wsn/component/WSNServiceUnit.java
Sending        
src/main/java/org/apache/servicemix/wsn/spring/PublisherComponent.java
Sending        
src/test/java/org/apache/servicemix/wsn/component/WSNComponentTest.java
Sending        
src/test/java/org/apache/servicemix/wsn/component/WSNSpringComponentTest.java
Transmitting file data ........
Committed revision 695854.

> Change endpoints lifecycle to use init / start / stop / shutdown
> ----------------------------------------------------------------
>
>                 Key: SM-1576
>                 URL: https://issues.apache.org/activemq/browse/SM-1576
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-common
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: 3.3
>
>
> Change servicemix-common in the following way:
>    * refactor the existing start / stop method into init / shutdown (along 
> with the doStart and doStop methods)
>    * add new start / stop methods with empty implementation in the Endpoint 
> class
>    * use these new init / start / stop / shutdown lifecycle in the service 
> unit
>    * implement start / stop for the polling endpoints
>    * implement start / stop for the jms consumer endpoint (it should start / 
> stop the listener container)
>    * implement start / stop for the http consumer (a stopped endpoint should 
> return an 503 Service Unavailable http status code)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to