[ 
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Mueller updated SM-1623:
----------------------------------

    Attachment: SmppProviderEndpoint.java.patch
                SmppConsumerEndpoint.java.patch

Hi Jean-Baptiste, hi Lars,

I provide two patches for the SmppComponents. The 
SmppConsumerEndpoint.java.patch fixed the NPE in SmppConsumerEndpoint, if no 
marshaler is explicit provided. The SmppProviderEndpoint.java.patch correct the 
validation of the availability of the password in
SmppProviderEndpoint, because the password is optional and not required (SMPP 
specification chapter 4.1.1 and 5.2.2).

Christian

> New binding component: SMPP
> ---------------------------
>
>                 Key: SM-1623
>                 URL: https://issues.apache.org/activemq/browse/SM-1623
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-components
>            Reporter: Rohit Joshi
>            Assignee: Jean-Baptiste Onofré
>         Attachments: DefaultSmppMarshaler.java.patch, endpointTimers.patch, 
> SmppConsumerEndpoint.java.patch, SmppProviderEndpoint.java.patch
>
>
> I am submitting here source code for SMPP binding component.   See the 
> attached tar file.  
> Attached servicemix-component.tar file contains following files. It should be 
> deployed under  apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
>  this file adds the dependency on smppapi.
> <dependency>
>             <groupId>smppapi</groupId>
>             <artifactId>smppapi</artifactId>
>             <version>0.3.7</version>
>             <optional>false</optional>
>  </dependency>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to