createContext method in ManagedContextManager is not normalizing paths properly
-------------------------------------------------------------------------------
Key: SMXCOMP-544
URL: https://issues.apache.org/activemq/browse/SMXCOMP-544
Project: ServiceMix Components
Issue Type: Bug
Components: servicemix-http
Affects Versions: servicemix-http-2009.01
Reporter: Jean Jacobs
Priority: Minor
I'm in the process of adding unit tests for the servicemix-http component. One
of the classes in this component is called ManagedContextManager. It has a
method called createContext() to add a context for a given URL and HTTP
processor to the map of managed contexts. There is some code in that method
that is confusing.
Following is the implementation of the method:
public synchronized Object createContext(String strUrl, HttpProcessor
processor) throws Exception {
URI uri = new URI(strUrl);
String path = uri.getPath();
if (!path.startsWith("/")) {
path = path + "/";
}
if (!path.endsWith("/")) {
path = path + "/";
}
managedContexts.put(path, processor);
return path;
}
It seems like if the path does not begin with "/" that it should be PRE-pended
to the path (not appended). I will attach a patch to fix this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
