jbi-maven-plugin should not filter out optional dependencies
------------------------------------------------------------

                 Key: SM-2045
                 URL: https://issues.apache.org/jira/browse/SM-2045
             Project: ServiceMix
          Issue Type: Bug
          Components: tooling
    Affects Versions: 4.0, jbi-maven-plugin-4.5
            Reporter: Kari J. Niemi


jbi-maven-plugin should not filter out optional dependencies of the 
project(pom.xml) that it's executed on. The optional element in maven denotes 
whether the dependency should be taken transitively for the _dependent_ 
projects -it is not supposed to have effect on project that defines the 
dependency as optional.

So I think "!artifact.isOptional()" should be removed from:
http://svn.apache.org/viewvc/servicemix/maven-plugins/jbi-maven-plugin/trunk/src/main/java/org/apache/servicemix/maven/plugin/jbi/GenerateServiceAssemblyMojo.java?view=markup
--------
if (!artifact.isOptional() && filter.include(artifact) && 
(artifact.getDependencyTrail().size() == 2)) {
---------
Also, the same might concern the component/su generation mojos...

The use case and problem I ran into:
I'm supposed to package an SA to an rpm from a different maven project(via the 
basic maven way: a dependency). It's really not necessary for those SA 
dependencies to be propagated transitively to the rpm project. Of course I 
tried the basic maven way and added the optional flag to the dependencies in 
the SA project. To my surprise,  the SA was empty when I built it. Yes, there 
are workarounds, but still this a bug in jbi-maven-plugin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to