Agreed. Also note that even when using the slf4j api, methods can only accept up to 3 parameters with no exceptions iirc. If you end up calling a method with vararg, you have to pay the cost of creating an Object[] array in all cases. So be cautious!
On Friday, February 4, 2011, Chris Custine <[email protected]> wrote: > +1 Ouch! Those "isDebugEnabled()" checks were there to prevent > unnecessary string concatenation. I agree with Gert that if we are > going to remove them we definitely need to use the slf4j message > methods to prevent it. This could potentially add significant > overhead in certain locations if we leave them like this. > > Chris > > -- > Chris Custine > FuseSource - Open Source Integration:: http://fusesource.com > My Blog :: http://blog.organicelement.com > > > > > > On Fri, Feb 4, 2011 at 09:39, Gert Vanthienen <[email protected]> > wrote: >> L.S., >> >> At several locations, this commit is dropping the if >> (...isDebugEnabled()) check before doing debug logging. I agree this >> is a good thing and improves readability of the code, but I think we >> should also move to using SLF4J's message format feature to pass the >> message format and the parameters instead of concatenating strings to >> create a message we won't be actually logging if debug logging is >> disabled. >> >> - if (log.isDebugEnabled()) { >> - log.debug("Remote invocation request: " + request); >> - } >> + logger.debug("Remote invocation request: " + request); >> >> Regards, >> >> Gert Vanthienen >> ------------------------ >> FuseSource >> Web: http://fusesource.com >> Blog: http://gertvanthienen.blogspot.com/ >> >> >> >> On Fri, Feb 4, 2011 at 10:05 AM, <[email protected]> wrote: >>> Author: jbonofre >>> Date: Fri Feb 4 09:05:47 2011 >>> New Revision: 1067118 >>> >>> URL: http://svn.apache.org/viewvc?rev=1067118&view=rev >>> Log: >>> [SMXCOMP-852] Switch to use SLF4J as default logger. >>> >>> Modified: >>> servicemix/components/trunk/bindings/servicemix-cxf-bc/pom.xml >>> servicemix/components/trunk/bindings/servicemix-file/pom.xml >>> >>> servicemix/components/trunk/bindings/servicemix-file/src/main/java/org/apache/servicemix/file/FilePollerEndpoint.java >>> >>> servicemix/components/trunk/bindings/servicemix-file/src/test/java/org/apache/servicemix/file/FilePollerEndpointTest.java >>> servicemix/components/trunk/bindings/servicemix-ftp/pom.xml >>> >>> servicemix/components/trunk/bindings/servicemix-ftp/src/main/java/org/apache/servicemix/ftp/FtpPollerEndpoint.java >>> servicemix/components/trunk/bindings/servicemix-http/pom.xml >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/AbstractHttpConsumerMarshaler.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/AbstractHttpProviderMarshaler.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/DefaultHttpConsumerMarshaler.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/SerializedMarshaler.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JCLLogger.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JaasUserRealm.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JettyContextManager.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ConsumerProcessor.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/test/java/org/apache/servicemix/http/ConsumerEndpointTest.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/test/java/org/apache/servicemix/http/HttpAddressingTest.java >>> >>> servicemix/components/trunk/bindings/servicemix-http/src/test/java/org/apac -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
