I think importing is okay… And yes, we really do not want to start sprinkling dynamic if we can avoid it.
On Aug 11, 2011, at 7:49 PM, Freeman Fang wrote: > Hi JB, > > Using dynamic-import isn't the best practice in OSGi world, though in some > cases we can't totally avoid it, but we should avoid using it as much as > possible. > In this case since we already know exactly which package we want to import, > using optional import should be better. > > Btw, though hibernate lib isn't Apache compatible license, just optional > import org.hibernate... package in pom.xml should be ok IMHO, if I'm wrong > here please correct me. > > Freeman > > On 2011-8-12, at 上午1:21, Jean-Baptiste Onofré wrote: > >> Hi Charles, >> >> isn't it possible to use dynamic import ? >> >> Regards >> JB >> >> On 08/11/2011 06:05 PM, Charles Moulliard wrote: >>> Hi, >>> >>> When using HQL token of Hibernate, we can use the Hibernate parser >>> (org.hibernate.hql.classic.ClassicQueryTranslatorFactory) or Hibernate >>> AST (based on Antlr - org.hibernate.hql.ast.ASTQueryTranslatorFactory) >>> to translate the query. In this case, the package >>> org.hibernate.hql.ast is needed by Antlr bundle. As we have in some >>> cases (random begavior due to resolution mechanism which is not >>> dynamic), some issues when adding this package using a fragment bundle >>> to Apache ServiceMix Antlr bundle, I would like to add it as an >>> optional package in the next release of Apache ServiceMix Antlr. >>> >>> Is it an issue ? >>> >>> Regards, >>> >>> Charles Moulliard >>> >>> Apache Committer >>> >>> Blog : http://cmoulliard.blogspot.com >>> Twitter : http://twitter.com/cmoulliard >>> Linkedin : http://www.linkedin.com/in/charlesmoulliard >>> Skype: cmoulliard >> >> -- >> Jean-Baptiste Onofré >> [email protected] >> http://blog.nanthrax.net >> Talend - http://www.talend.com > > --------------------------------------------- > Freeman Fang > > FuseSource > Email:[email protected] > Web: fusesource.com > Twitter: freemanfang > Blog: http://freemanfang.blogspot.com > > > > > > > > >
