[
https://issues.apache.org/jira/browse/SMXCOMP-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129069#comment-13129069
]
Ryan Moquin commented on SMXCOMP-622:
-------------------------------------
I had a need to be able to use Jetty 8.x with the servicemix-http component, so
this past weekend I took the latest from trunk and upgraded it locally. I
rewrote the continuation handling code (the ContinuationHelper class isn't
needed anymore and is removed) since the changes were pretty extensive in
regards to what was there. There are some errors present in the current source
in trunk which I made sure were corrected:
-One was a memory leak due to exchanges not getting marked done when the
consumer component received the response late, it set an Error on the late
response instead of marking it done. I changed the test to test for done
instead and commented the test for review.
- There was also another instance or two of the exchange status being set to
Error when it wasn't the owner, rather than sending the error back as the
response like it should.
- A test for the Provider Enpoint loading the timeout value from the component
config started failing intermittently, looks like it never read the timeout
from the component config (like it does for the consumer endpoint), so I
modified the test and fixed it (pretty sure I'm correct).
- I also deleted one of the tests, HttpWsdlTest was the name I think, since it
used a servicemix test components jar which needs updated (just an import in
HttpComponent, should be simple).
- I didn't update the OSGI bundle property versions for jetty, I haven't
migrated to OSGI yet and thought maybe I would leave that to you guys to
change. I'm guessing it just requires the version numbers changed.
Other than that, all the other 111 tests fully pass. I did upped the timeout
on the HttpConsumerEndpointTest load test to 1 second to eliminate all the late
response timeouts. That test still has a weird error that it loggs but the
test still passes, it's one of those parsing errors that has no detail. I
didn't find the cause.
I've tested the built artifact in our software and so far it's worked perfectly
without any issues. Please review the attached for updating trunk (as well as
the notes I made above). As of right now, what I'm attaching is modified
directly from the latest source, so you could just overlay it on a working copy
from trunk (the zip is an export of the source, so there isn't any svn stuff,
target dir or other unnecessary stuff). You should be able to downgrade to a
jetty 7.x version in the pom if that's desired instead, in my experience it
requires no code changes, though hopefully you'll leave it at 8.x. Let me know
if you have any questions. The attached should put you at a minimum of 95% of
the way (due to the comments above).
> Upgrade to Jetty 7
> ------------------
>
> Key: SMXCOMP-622
> URL: https://issues.apache.org/jira/browse/SMXCOMP-622
> Project: ServiceMix Components
> Issue Type: Improvement
> Components: servicemix-http
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
>
> The new HTTP endpoint basic authentication is limited due to the Jetty
> HttpClient used. Upgrading to Jetty 7 provide a lot of enhancement including
> in the HttpClient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
