Hi Wim,

Thanks for testing CXF related examples.

My comment inline
-------------
Freeman(Yue) Fang

Red Hat, Inc. 
FuseSource is now part of Red Hat
Web: http://fusesource.com | http://www.redhat.com/
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com
http://blog.sina.com.cn/u/1473905042
weibo: @Freeman小屋



On 2013-6-28, at 下午6:24, Wim Verreydt wrote:

> +1 but I encountered the following (non-critical) issues in the examples:
> 
> examples-cxf-ws-rm:
>       client not executing
This is due to miss necessary spring dependency, add
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-context</artifactId>
        </dependency>
to cxf-ws-rm/pom.xml
can make it work

SMX4-1492 tracked this issue and I don't consider this as a show stopper,  so 
we will fix it for next release
>       
> examples-cxf-ws-security-blueprint 
>       client.html not working due to Access-Control-Allow-Origin
> 
> examples-cxf-ws-security-osgi 
>       client.html not working due to Access-Control-Allow-Origin
As both examples have EnableCORSInterceptor already, so the client.html works 
by my test, both in firefox and safari.
If you're using chrome, you will hit a known chrome issue[1] in this area, 
that's not something can be done in Servicemix side
[1]http://code.google.com/p/chromium/issues/detail?id=67743
>       
> examples-cxf-wsdl-first-osgi-package
>       the example is present in the 
> ./system/org/apache/servicemix/examples/cxf-wsdl-first-osgi-package so it can 
> be run but the sources and the client are not included in the ./examples 
> folder
this is jbi example
>       
> examples-nmr 
>       the example is present in the 
> ./system/org/apache/servicemix/examples/org.apache.servicemix.examples.nmr.* 
> so it can be run but the sources are not included in the ./examples folder
I guess you are using full kit to test it, right?
The nmr and jbi related examples are only in jbi kit so won't shipped with 
other kind kit so this is kinda expected behavior.

In a summary, I'm still +1 for this release.

Regards
> 
> Wim
> 
> On 27 Jun 2013, at 16:40, Gert Vanthienen <[email protected]> wrote:
> 
>> L.S.,
>> 
>> 
>> We've uploaded a release for Apache ServiceMix 4.5.2 to
>> https://repository.apache.org/content/repositories/orgapacheservicemix-080/
>> 
>> An overview of issues fixed in this release can be found in JIRA at
>> https://issues.apache.org/jira/browse/SMX4/fixforversion/12324246
>> 
>> The scm tag is available on
>> https://svn.apache.org/repos/asf/servicemix/smx4/features/tags/features-4.5.2/
>> 
>> As part of this, we also created an Apache ServiceMix NMR 1.6.1 release:
>> https://repository.apache.org/content/repositories/orgapacheservicemix-078/
>> https://issues.apache.org/jira/browse/SMX4NMR/fixforversion/12324649
>> http://svn.apache.org/repos/asf/servicemix/smx4/nmr/tags/nmr-parent-1.6.1/
>> 
>> 
>> Please vote to approve these two releases:
>> 
>> [ ] +1 Approve the release
>> [ ] -1 Do not approve the release (please provide specific comments)
>> 
>> This vote will be open for 72 hours.
>> 
>> 
>> Regards,
>> 
>> Gert Vanthienen
> 

Reply via email to