[ 
https://issues.apache.org/jira/browse/SMX4-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792589#comment-13792589
 ] 

Justas Samuolis commented on SMX4-1585:
---------------------------------------

I think then Exception is catched it would be better to remove  
e.printStackTrace(); and use LOG.error(e.getMessage(), e) instead.

> org.apache.servicemix.cxf.transport.nmr.NMRConduitOutputStream.commitOutputMessage()
>  does not propagate exception.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4-1585
>                 URL: https://issues.apache.org/jira/browse/SMX4-1585
>             Project: ServiceMix 4
>          Issue Type: Bug
>          Components: cxf-nmr
>         Environment: CXF-NMR transport
>            Reporter: Torsten Mielke
>            Assignee: Freeman Fang
>              Labels: cxf-nmr
>             Fix For: 4.5.3, 4.6.0
>
>         Attachments: SMX4-1585.patch
>
>
> There is a bug in 
> {code:title=org.apache.servicemix.cxf.transport.nmr.NMRConduitOutputStream.java
>  }
> private void commitOutputMessage() throws IOException {
>     try {
>     ...
>     } catch (Exception e) {
>         e.printStackTrace();
>         new IOException(e.toString());
>     }
> {code}
> Notice it creates a new IOException but never throws it. As a result the 
> error is ignored completely.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to