j3rem1e commented on code in PR #183:
URL: https://github.com/apache/servicemix-bundles/pull/183#discussion_r965569617


##########
poi-5.2.2/pom.xml:
##########
@@ -258,34 +259,44 @@
                                 <excludes>
                                     <exclude>*:*:*:sources</exclude>
                                     
<exclude>${project.groupId}:${project.artifactId}:*:sources</exclude>
+                                    
<exclude>org.apache.logging.log4j:*</exclude>
                                 </excludes>
                             </artifactSet>
                             <filters>
-                                <filter>
+                               <filter>
                                     <artifact>${pkgGroupId}:poi</artifact>
-                                    <excludes>
-                                        <exclude>**</exclude>
-                                    </excludes>
-                                </filter>
+                                    <includes>
+                                        <include>META-INF/services/**</include>
+                                    </includes>
+                               </filter>
                                 <filter>
                                     
<artifact>${pkgGroupId}:poi-scratchpad</artifact>
-                                    <excludes>
-                                        <exclude>**</exclude>
-                                    </excludes>
+                                    <includes>
+                                        <include>META-INF/services/**</include>
+                                    </includes>
                                 </filter>
                                 <filter>
                                     
<artifact>${pkgGroupId}:poi-ooxml</artifact>
-                                    <excludes>
-                                        <exclude>**</exclude>
-                                    </excludes>
+                                    <includes>
+                                        <include>META-INF/services/**</include>
+                                    </includes>
+                                </filter>
+                                                               <filter>
+                                    
<artifact>${pkgGroupId}:poi-ooxml-lite</artifact>
+                                    <includes>
+                                        <include>META-INF/services/**</include>
+                                    </includes>
                                 </filter>
                                 <filter>
                                     
<artifact>com.github.virtuald:curvesapi</artifact>
-                                    <excludes>
-                                        <exclude>**</exclude>
-                                    </excludes>
+                                    <includes>

Review Comment:
   and the maven-bundle-plugin can merge the services like 
ServicesResourceTransformer ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to