Re: [servicemix-dev] JMSFlow architecture questions

[Rob Davies]

ooh - Bug - how nice it is to have code reviewed :)  cheers, Rob On 16 Nov 2005, at 23:21, Peter Smith wrote: Rob Davies wrote: [snip...] If I understand the onEvent(ConsumerAdvisoryEvent event) method correctly then that will mean that if a lot of containers get started, then the same ComponentPacketEvents will be sent to the broadcast Topic a number of times. That would mean most of the (already started) containers will be told again and again about remote components that they already know about. Is that true? How is the addRemotePacket method is accounting for this scenario (???) Yes this is true - but the ComponentRegistry only gets updated if it doesn't already know about the activation of the Component Does it though? The condition in ComponentRegistry.addComponentConnector doesn't look correct to me...     public void addComponentConnector(ComponentConnector connector) {         if (!idMap.containsKey(connector)) {             idMap.put(connector.getComponentNameSpace(), connector);         }     } Let me know if you confirm this is a bug & I'll report it in JIRA. Cheers, Peter.