Thanks, i was just looking at them.
I'm currently updating them and writing a maven plugin
to call them.
Cheers,
Guillaume Nodet
Peter Smith wrote:
I had a look at management Ant Tasks and trying to see how it works
and also to reconcile the ServiceMix implementations with the JBI spec
section 6.10.
FYI a number of findings/questions
==========
Other miscellaneous stuff:....
#1 StartAssemblyTask.java
comment seems wrong
private String assemblyName; //assemblyName to get descriptor for
---
#2 StopAssemblyTask
comment of no use :-)
private String assemblyName; //assemblyName
---
#3 AssemblyDescriptorTask
I have no idea about this but it just seemed odd that is is calling:
String[] sus = is.getDeployedServiceUnitList(assemblyName);
it looks like cut/paste error from DeployedServiceUnitsTask
---
#4 InstallComponentTask
Maybe it is cleaner to remove the test
if (archivePath.endsWith(".zip") || archivePath.endsWith(".jar")){
since isn't this already done inside AutoDeploymentSerive.unpackLocation
#4b Ditto for InstallSharedLibraryTask
if (sharedLibURI.endsWith(".zip") || sharedLibURI.endsWith(".jar")){
#4c Ditto for InstallAssemblyTask
if (archivePath.endsWith(".zip") || archivePath.endsWith(".jar")){
----
#5 StartComponentTask, StopComponentClass, ShutdownComponentTask
is the catch:
catch (Exception e) {
a typo that was meant to catch JBIException instead?
#5b UninstallAssemblyTask, StartAssemblyTask, StopAssemblyTask,
ShutdownAssemblyTask, DeployedAssembliesTask, DeployedServiceUnitsTask
similar doubled-up catch with identical logic
----
#6 DeployedAssembliesTask
sa == null seems not possible so no need to test
----
#7 DeployedServiceUnitsTask
sus == null seems not possible so no need to test
Cheers,
Peter
