On 7/5/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:

On 7/5/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> Author: craigmcc
> Date: Wed Jul  5 12:07:29 2006
> New Revision: 419315
>
> URL: http://svn.apache.org/viewvc?rev=419315&view=rev
> Log:
> First-pass checkstyle cleanup on shale-tiger.  It looks like Checkstyle
rules
> will definitely need to be customized for JDK 1.5 generics.

We can have shale_tiger_checks.xml, and override the Checkstyle plugin
configuration in the modules that need it.


That'd be good ... but this is probably feedback that needs to go back to
the Checkstyle folks too.  Consider the variable declaration:

   // Map of mybean instances, keyed by id string
   private Map<String,MyBean> mybeans;

The current checkstyle rules complain about lack of spaces around the "<",
",", and ">" characters.  Normally, you'd want those ... but NOT in this
particular case.  I would hate to have to write

   private Map < String , MyBean > mybeans;

just to get past the Checkstyle rules :-)

--
Wendy



Craig

Reply via email to