On 9/14/06, Gary VanMatre <[EMAIL PROTECTED]> wrote:
>From: [EMAIL PROTECTED] > > Author: craigmcc > Date: Wed Sep 13 23:16:55 2006 > New Revision: 443256 > > URL: http://svn.apache.org/viewvc?view=rev&rev=443256 > Log: > Implement a fairly massive refactoring of our Maven2 build dependencies, > and (along the way) address the issues raised by SHALE-258 (although > they are probably not completely covered yet). Highlights of the > changes: > > * Dependencies to compile the Shale Framework libraries have been > adjusted to always use the MyFaces API jar (it should not matter > which implementation is used to compile against, because the signature > tests in the TCK will ensure method signature compatibility). > > * Migrate as many dependency version numbers as possible into the > section of the shale-parent POM, along with > exclusions that avoid adding optional dependencies to the classpath. > > * Move the profile stuff about choosing MyFaces or the JSF RI into the > shale-apps-parent POM, instead of shale-parent, since this now only > affects webapps. > > * There is a wierd test failure on the shale-clay unit tests that I > could not figure out, so I commented out those test cases for now. > Gary, could you take a look at CommentTestCase? > This test is building the component tree and rendering the output. The output is parsed and checked for an embed comment. Since the myfaces-impl is not a dependency, the renderers are not being loaded and no markup generated.
Ah ... that makes sense. I could create some mock renderers for this test. That would be
much easier than starting a wrestling match with maven.
That definitely sounds like a good plan. Gary
Craig
