On 11/18/06, Rahul Akolkar <[EMAIL PROTECTED]> wrote:

On 11/10/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> Author: craigmcc
> Date: Fri Nov 10 20:16:19 2006
> New Revision: 473638
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=473638
> Log:
> Partial fix for cleaning up static resources at application shutdown
> (SHALE-274) for the basic implementation.  This took several changes:
<snip/>
>
> Modified: shale/framework/trunk/shale-dialog-basic/pom.xml
> URL:
http://svn.apache.org/viewvc/shale/framework/trunk/shale-dialog-basic/pom.xml?view=diff&rev=473638&r1=473637&r2=473638
>
==============================================================================
> --- shale/framework/trunk/shale-dialog-basic/pom.xml (original)
> +++ shale/framework/trunk/shale-dialog-basic/pom.xml Fri Nov 10 20:16:19
2006
> @@ -40,6 +40,23 @@
>          </dependency>
>
>          <dependency>
> +            <groupId>commons-logging</groupId>
> +            <artifactId>commons-logging</artifactId>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>javax.servlet</groupId>
> +            <artifactId>jsp-api</artifactId>
> +            <scope>provided</scope>
> +        </dependency>
> +
<snap/>

Why jsp-api here?


From a minimalist perspective, we would need only servlet-api here ( because
we are now implementing a ServletContextListener).  However, we are also
well and truly depending on having a JSP container to run on, because we are
using the "define a listener in the TLD" trick to avoid needing the
developer to modify web.xml.

-Rahul


Craig


+        <dependency>
> +            <groupId>javax.servlet</groupId>
> +            <artifactId>servlet-api</artifactId>
> +            <scope>provided</scope>
> +        </dependency>
> +
<snip/>

Reply via email to