Hi
Ok, I am ready to submit the patch for this. However there are som issues that
need to be dealt with before I submit.
1. The tool now adds a validator attribute to each component if one is defined
for the tld it self (It is a separate entry in the tld apart from the tags them
self)
<component jsfid="hx:commandExButton"
componentType="com.ibm.faces.HtmlCommandExButton"
validator="com.ibm.faces.taglib.JWLTagLibraryValidator"
extends="baseComponent">
There is a problem with the dtd for the Clay components here:
<!ELEMENT component (description*, attributes?, symbols?, converter?, ,*,
actionListener*, valueChangeListener*, element*)>
<!ATTLIST component jsfid CDATA #REQUIRED
extends CDATA #IMPLIED
componentType CDATA #IMPLIED
id CDATA #IMPLIED
allowBody %Boolean; #IMPLIED
facetName CDATA #IMPLIED
>
Even though it is stated in the comment above the declaration :
...
validator - A component can have zero or many associated validators. Only
components that
implement the EditableValueHolder interfaces can be assigned validators.
This rule
is enforced at runtime and not through this document type definition.
..
It is not defined in the component it self. Also since the jsf dtd only
specifies a single validator declaration, there is no way that the Clay
compenent definition that maps jsf component libraries can have more than one
validator assigned.
2. Regarding converters, I have skimmed through the trinidad stuff and the only
reference to converters are as attributes to the tags:
<attribute>
<name>converter</name>
<rtexprvalue>false</rtexprvalue>
<description>a converter object</description>
</attribute>
The converters are now mapped as attributes to the Clay components:
<set name="converter" bindingType="MB"></set>
3. The rendererType is also mapped as an attribute:
<set name="rendererType" value="com.ibm.faces.Button"></set>
Hermod
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Monday, January 29, 2007 9:12 AM
To: dev@shale.apache.org
Subject: RE: svn commit: r500112
-/shale/sandbox/maven/archetypes/shale-clay-starter-archetype/src/main/r
esources/archetype-resources/src/main/webapp/WEB-INF/validator-rules.xml
Hi
I had already done the rendererType, but was waiting to file a Jira on it until
I had added the converters and validators. Since you hav done something here,
could you send it to me and I'll look at it.
Hermod
-----Original Message-----
From: Gary VanMatre [mailto:[EMAIL PROTECTED]
Sent: Friday, January 26, 2007 5:47 PM
To: dev@shale.apache.org
Subject: RE: svn commit: r500112
-/shale/sandbox/maven/archetypes/shale-clay-starter-archetype/src/main/r
esources/archetype-resources/src/main/webapp/WEB-INF/validator-rules.xml
>From: <[EMAIL PROTECTED]>
>
> Hi
>
> Thanks Gary. I had missed that one in the cleanup.
>
If I can find the time this weekend, I'm going to try cloning your archetype
making one that focuses on trinidad. Then we can move on to other component
libraries.
I also made some hacks to your maven plugin to add the rendererType and include
converters and validators. It is a "hack" and didn't feel right committing it
:-)
> Hermod
>
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Friday, January 26, 2007 3:39 AM
> To: commits@shale.apache.org
> Subject: svn commit: r500112
> -/shale/sandbox/maven/archetypes/shale-clay-starter-archetype/src/main/r
> esources/archetype-resources/src/main/webapp/WEB-INF/validator-rules.xml
>
>
> Author: gvanmatre
> Date: Thu Jan 25 18:38:49 2007
> New Revision: 500112
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=500112
> Log:
> Removed unused file (SHALE-391).
>
> Removed:
>
> shale/sandbox/maven/archetypes/shale-clay-starter-archetype/src/main/resources/a
>
> rchetype-resources/src/main/webapp/WEB-INF/validator-rules.xml
>
>
>
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
>
> This email with attachments is solely for the use of the individual or
> entity to whom it is addressed. Please also be aware that the DnB NOR Group
> cannot accept any payment orders or other legally binding correspondence with
> customers as a part of an email.
>
> This email message has been virus checked by the anti virus programs used
> in the DnB NOR Group.
>
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
>
