On Wed, Jun 4, 2008 at 8:00 AM, Paul Spencer <[EMAIL PROTECTED]> wrote:

> -1 The copyright date in the notice file is 2007 instead of 2008
> Aside from the copyright date, noted above, I only verified that notice.txt,
> manifest.mf and license.txt existed

Probably needs to be fixed, though I could argue that If there haven't
been any significant code changes this year, then 2007 may be correct.
 The copyright date starts when something is created, and I'm not sure
packaging existing stuff==creation.  I wouldn't stop the release
because of this if it's the only problem.

> The artifact where built using JDK 1.5.0_13.  Should they be built using 1.4?

I trust the 1.5 compiler to properly create 1.4 jars, assuming we have
the compiler plugin configured correctly to target 1.4.  Otherwise,
since the tiger module _must_ be built with 1.5, you'd have to release
it separately.  I don't recally having to do that, but it's been a
long time.

Thanks for looking it over!

-- 
Wendy

Reply via email to