cherrylzhao commented on a change in pull request #1825: for #1812 make
ShardingTransactionManager support multi instance.
URL:
https://github.com/apache/incubator-shardingsphere/pull/1825#discussion_r251219196
##########
File path:
sharding-transaction/sharding-transaction-core/src/main/java/org/apache/shardingsphere/transaction/ShardingTransactionManagerEngine.java
##########
@@ -36,24 +34,35 @@
*
* @author zhaojun
*/
-@NoArgsConstructor(access = AccessLevel.PRIVATE)
@Slf4j
public final class ShardingTransactionManagerEngine {
- private static final Map<TransactionType, ShardingTransactionManager>
TRANSACTION_MANAGERS = new HashMap<>();
+ private final Map<TransactionType, ShardingTransactionManager>
cachedTransactionManager = new HashMap<>();
Review comment:
the transaction manager used by one shardingDataSource，this is same as
before，would not clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
