terrymanu commented on a change in pull request #2038: #2034 bug fixs && add encrypt test class URL: https://github.com/apache/incubator-shardingsphere/pull/2038#discussion_r266227316
########## File path: sharding-core/sharding-core-parse/sharding-core-parse-mysql/src/main/antlr4/imports/mysql/BaseRule.g4 ########## @@ -20,27 +20,45 @@ grammar BaseRule; import Keyword, DataType, Symbol; ID - : (BQ_?[a-zA-Z_$][a-zA-Z0-9_$]* BQ_? DOT_)? (BQ_?[a-zA-Z_$][a-zA-Z0-9_$]* BQ_?) + : [A-Za-z_$0-9]*?[A-Za-z_$]+?[A-Za-z_$0-9]* + ; + +REVERSE_QUOTE_ID + : '`' ~'`'+ '`' + ; + +uid + : ID + | REVERSE_QUOTE_ID + | keywordCanBeID + ; + +keywordCanBeID + : DATE | PASSWORD + ; + +fullID Review comment: what is full id? qualified name? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
