Agree to release +1-- ---------------------------------
HongJun Du Apache ShardingSphere At 2019-03-27 11:34:17, "[email protected]" <[email protected]> wrote: >I summarize the issues we received on this thread: > >1. PR for [1], missing some licenses, already merged. >2. Sharding-proxy can’t run for lacking of some jars, reason is from OS >file path setting, not ShardingSphere issue. >3. Navicat premium 12 connect sharding-proxy using MySQL protocol, it >connected but no database. Fixed at PR[2]. >4. Some DISTINCT SQL loses data, submit a issue[3] and make sure it is not >a blocking issue. >5. Compile error by guangyuan wang, caused by his environment. Travis can >compile success, FYI[4] > >All blocking issues are resolved and some unblocking issue are recorded, >will fix next version. >So can we do release now? Any suggestion? > >[1] https://github.com/apache/incubator-shardingsphere/pull/2078 >[2] https://github.com/apache/incubator-shardingsphere/pull/2102 >[3] https://github.com/apache/incubator-shardingsphere/issues/2094 >[4]https://travis-ci.org/apache/incubator-shardingsphere >------------------ > >Liang Zhang (John) >Apache ShardingSphere & Dubbo > > > >[email protected] <[email protected]> 于2019年3月27日周三 上午11:24写道： > >> Hi guangyuan wang, >> >> This is caused by your environment. Please check travis : >> https://travis-ci.org/apache/incubator-shardingsphere get more details. >> >> >> ------------------ >> >> Liang Zhang (John) >> Apache ShardingSphere & Dubbo >> >> >> guangyuan wang <[email protected]> 于2019年3月27日周三 上午11:19写道： >> >>> After executed "mvn clean install",it shows: >>> [ERROR] Failed to execute goal on project sharding-core-parse-mysql: Could >>> not resolve dependencies for project >>> org.apache.shardingsphere:sharding-core-parse-mysql:jar:4.0.0-RC1: Failed >>> to collect dependencies at >>> org.apache.shardingsphere:sharding-core-parse-spi:jar:4.0.0-RC1: Failed to >>> read artifact descriptor for >>> org.apache.shardingsphere:sharding-core-parse-spi:jar:4.0.0-RC1: Failure >>> to >>> find org.apache.shardingsphere:sharding-core:pom:4.0.0-RC1 in >>> https://repo.maven.apache.org/maven2 was cached in the local repository, >>> resolution will not be reattempted until the update interval of central >>> has >>> elapsed or updates are forced -> [Help 1] >>> >>> >>> duhongjun <[email protected]> 于2019年3月26日周二 下午4:29写道： >>> >>> > use antlr parse SQL statement, Lexer and Parser class are generated by >>> > antlr maven plugin >>> > execute mvn clean install in sharding-core-parse-mysql project or >>> parent >>> > project >>> > after execute command successfully，the source code is generated in >>> > target/generated-sources/antlr4 directory >>> > >>> > >>> > >>> > >>> > >>> > -- >>> > >>> > --------------------------------- >>> > >>> > HongJun Du >>> > Apache ShardingSphere >>> > >>> > >>> > >>> > At 2019-03-26 14:14:07, "guangyuan wang" <[email protected]> wrote: >>> > >Please see org.apache.shardingsphere.core.parse.H2ShardingParseEngine >>> > class >>> > >in 4.0.0 RC1 source code. >>> > > >>> > >In IntelliJ IDEA shows : Missing >>> > org.apache.shardingsphere.core.parse.antlr. >>> > >autogen.MySQLStatementLexer. >>> > > >>> > >After checked,I found MySQLStatementLexer.class does not exist in the >>> > >source code. >>> > > >>> > >On 2019/03/25 03:02:16, "[email protected]" <[email protected]> wrote: >>> > >> Hello ShardingSphere Community,> >>> > >> >>> > >> This is a call for discuss to release Apache ShardingSphere >>> > (Incubating)> >>> > >> version 4.0.0-RC1> >>> > >> >>> > >> Release notes:> >>> > >> >>> > > >>> > >>> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-90bdf1e5cbba8422332f >>> > > >>> > > >>> > >> >>> > >> The release candidates:> >>> > >> >>> > >>> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC1/ >>> > > >>> > > >>> > >> >>> > >> Maven 2 staging repository:> >>> > >> >>> > > >>> > >>> https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ >>> > > >>> > > >>> > >> >>> > >> Git tag for the release:> >>> > >> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC1> >>> > >> >>> > >> Release Commit ID:> >>> > >> >>> > > >>> > >>> https://github.com/apache/incubator-shardingsphere/commit/90a17fd3ac5af99d0fe1bd8018ba1393b1864672 >>> > > >>> > > >>> > >> >>> > >> Keys to verify the Release Candidate:> >>> > >> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS >>> > >>> > >> >>> > >> Every who inserted can be do acceptance test and discuss this >>> version> >>> > >> should be release or not.> >>> > >> >>> > >> ------------------> >>> > >> >>> > >> Liang Zhang (John)> >>> > >> Apache ShardingSphere & Dubbo> >>> > >> >>> > >>> >>
