cherrylzhao commented on issue #115: Add a broadcast-table example for sharding-jdbc URL: https://github.com/apache/incubator-shardingsphere-example/issues/115#issuecomment-480758637 @betterjava I have reviewed your PR, there exist 2 main problem that we can optimize. 1. we should delete by code instead of id, I think we can add a generic type for delete parameter to support other parameter type like string. 2. we should add a new `CountryServiceImpl` in jdbc-repository/jpa-repository/mybatis-repository like we have done in UserServiceImpl. because of other scenario example doesn't need broadcast feature.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
