Juan

Try GitHub action first, it is faster, and doesn't require INFRA to setup.

Sheng Wu 吴晟

Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108


Juan Pan <panj...@apache.org> 于2019年11月8日周五 下午3:09写道:

> Yep, the feedback from three of folks convinced us that our release can
> not install well on window platform.
>
>
> I will handle this new issue ASAP, therefore i am sorry to tell everyone
> vote for this release is delayed by a new issue, i.e across platform
> exception, and please wait for next ROUND.
>
>
> Thanks, Sheng, appveyor is exactly what we need. :)
>
>
>
>
>  Juan Pan
>
>
> panj...@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>
> On 11/8/2019 14:41,Sheng Wu<wu.sheng.841...@gmail.com> wrote:
> Look like an across platforms test fails.
> A suggestions, SkyWalking is using appveyor[1] to do Windows compiling
> check today. I think GitHub action also supports windows.
> We should choose one. Because SkyWalking used to face the same issue, some
> codes/tests are not working in Windows.
>
>
> [1] https://ci.appveyor.com/project/ApacheSoftwareFoundation/skywalking/
>
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
>
> 王海涛 <wanghaita...@jd.com.invalid> 于2019年11月8日周五 下午2:36写道:
>
> Me too. In window 7, when I install the whole project , the same error was
> occurred.
> "Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.667 s
> <<< FAILURE! - in
> org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest
>
> assertInitDataSource(org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest)
> Time elapsed: 0.512 s  <<< FAILURE!"
>
> -----邮件原件-----
> 发件人: Zhang Yonglun [mailto:zhangyong...@apache.org]
> 发送时间: 2019年11月8日 14:27
> 收件人: dev <dev@shardingsphere.apache.org>
> 主题: Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3
>
> OS: Windows7
>
> JDK: 1.8.0_162"
>
> mvn install or run the single test case MySQLTimeServiceTest can cause
> that failure.
>
> Juan Pan <panj...@apache.org> 于2019年11月8日周五 下午1:41写道:
>
> Hi Yonglun,
>
>
> Thanks for your feedback. Actually, the exception you mentioned didn’t
> happened to me,  either i run `MySQLTimeServiceTest` separately or
> installed the whole project. Can you provide more details about your
> runtime environment or test procedure?
>
>
> Juan Pan
>
>
> panj...@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>
> On 11/8/2019 13:25,Zhang Yonglun<zhangyong...@apache.org> wrote:
> I have installed the source code and a unit test failed:
>
> [INFO] -------------------------------------------------------
> [INFO]  T E S T S
> [INFO] -------------------------------------------------------
> [INFO] Running
> org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.48 s <<< FAILURE! - in
> org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest
> [ERROR]
>
> assertInitDataSource(org.apache.shardingsphere.route.time.mysql.MySQLT
> imeServiceTest)
> Time elapsed: 0.329 s  <<< FAILURE!
> java.lang.AssertionError
> at
>
> org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest.assert
> InitDataSource(MySQLTimeServiceTest.java:48)
>
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR]   MySQLTimeServiceTest.assertInitDataSource:48
>
> The root cause is the inputStream is not close then leading to a file
> close failure.
>
> The source code: 55th line of MySQLTimeService.java
>
>
>
> linzesi <geo...@163.com> 于2019年11月8日周五 上午10:32写道:
>
>
>
> +1.
>
>
> checked list:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current
> release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> [X] All files have license headers if necessary.
> [X] No compiled archives bundled in source archive.
> On 11/8/2019 10:24,董。<598363...@qq.com> wrote:
> +1.
>
>
> checked list:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current
> release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> [X] All files have license headers if necessary.
> [X] No compiled archives bundled in source archive.
>
>
>
> Best wishes.
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:&nbsp;"Sion Yang"<schoolp...@163.com&gt;;
> 发送时间:&nbsp;2019年11月8日(星期五) 上午9:21
> 收件人:&nbsp;"dev"<dev@shardingsphere.apache.org&gt;;
>
> 主题:&nbsp;Re:Re: [VOTE] Release Apache ShardingSphere (Incubating)
> 4.0.0-RC3 ROUND 3
>
>
>
> +1.
>
> I checked:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current
> release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> [X] All files have license headers if necessary.
> [X] No compiled archives bundled in source archive.
>
>
>
>
> --
>
> Yi Yang(Sion)
> Apache ShardingSphere
>
>
>
> At 2019-11-07 20:23:18, "zhangli...@apache.org"
> <zhangli...@apache.org&gt;
> wrote:
> &gt;+1.
> &gt;
> &gt;I checked:
> &gt;
> &gt;[X] Download links are valid.
> &gt;[X] Checksums and PGP signatures are valid.
> &gt;[X] DISCLAIMER is included.
> &gt;[X] Source code artifacts have correct names matching the current
> release.
> &gt;[X] LICENSE and NOTICE files are correct for each ShardingSphere
> repo.
> &gt;[X] All files have license headers if necessary.
> &gt;[X] No compiled archives bundled in source archive.
> &gt;
> &gt;------------------
> &gt;
> &gt;Liang Zhang (John)
> &gt;Apache ShardingSphere &amp; Dubbo
> &gt;
> &gt;
> &gt;Juan Pan <panj...@apache.org&gt; 于2019年11月7日周四 下午7:34写道:
> &gt;
> &gt;&gt; Hi ShardingSphere Community,
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; I tried my best to solve the issues you raised, and went
> through the check &gt;&gt; list twice to avoid the confusion, but your
> review and vote on this release &gt;&gt; is important to us. Look
> forward to your attention and interaction.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; Release notes:
> &gt;&gt;
> &gt;&gt;
>
> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NO
> TES.md
> &gt;&gt
> <https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-N
> OTES.md&gt;&gt
> <https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md&gt;&gt>
> >
> <
> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NO
> TES.md&gt;&gt
> <https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md&gt;&gt>
>
> ;
> &gt;&gt;
> &gt;&gt; The release candidates:
> &gt;&gt;
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-
> RC3/
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/>
> &gt;&gt
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0
> -RC3/&gt;&gt
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/&gt;&gt>
> >
> <
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-
> RC3/&gt;&gt
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/&gt;&gt>
>
> ;
> &gt;&gt;
> &gt;&gt; Maven 2 staging repository:
> &gt;&gt;
> &gt;&gt;
>
> https://repository.apache.org/content/repositories/orgapacheshardingsp
> here-1026/org/apache/shardingsphere/
> <https://repository.apache.org/content/repositories/orgapacheshardingsphere-1026/org/apache/shardingsphere/>
> &gt;&gt
> <https://repository.apache.org/content/repositories/orgapacheshardings
> phere-1026/org/apache/shardingsphere/&gt;&gt
> <https://repository.apache.org/content/repositories/orgapacheshardingsphere-1026/org/apache/shardingsphere/&gt;&gt>
> >
> <
> https://repository.apache.org/content/repositories/orgapacheshardingsp
> here-1026/org/apache/shardingsphere/&gt;&gt
> <https://repository.apache.org/content/repositories/orgapacheshardingsphere-1026/org/apache/shardingsphere/&gt;&gt>
>
> ;
> &gt;&gt;
> &gt;&gt; Git tag for the release:
> &gt;&gt;
> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
> &gt;&gt
> <https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/&gt;&gt>
> <https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/&gt
> ;&gt>
> <https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/&gt
> ;&gt
>
> ;
> &gt;&gt;
> &gt;&gt; Release Commit ID:
> &gt;&gt;
> &gt;&gt;
>
> https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693
> bde04b7e0742386fdcb94b93bd60
> <https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693bde04b7e0742386fdcb94b93bd60>
> &gt;&gt
> <https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff69
> 3bde04b7e0742386fdcb94b93bd60&gt;&gt
> <https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693bde04b7e0742386fdcb94b93bd60&gt;&gt>
> >
> <
> https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693
> bde04b7e0742386fdcb94b93bd60&gt;&gt
> <https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693bde04b7e0742386fdcb94b93bd60&gt;&gt>
>
> ;
> &gt;&gt;
> &gt;&gt; Keys to verify the Release Candidate:
> &gt;&gt;
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
> &gt;&gt
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS&gt;&gt>
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS&;
> gt;&gt>
> <
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS&g
> t;&gt
>
> ;
> &gt;&gt;
> &gt;&gt; Look at here for how to verify this release candidate:
> &gt;&gt;
> https://shardingsphere.apache.org/community/en/contribute/release/
> &gt;&gt
> <https://shardingsphere.apache.org/community/en/contribute/release/&gt;&gt>
> <https://shardingsphere.apache.org/community/en/contribute/release/&gt
> ;&gt>
> <https://shardingsphere.apache.org/community/en/contribute/release/&gt
> ;&gt
>
> ;
> &gt;&gt;
> &gt;&gt; The vote will be open for at least 72 hours or until
> necessary number of &gt;&gt; votes are reached.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; Please vote accordingly:
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] +1 approve
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] +0 no opinion
> &gt;&gt;
> &gt;&gt; [ ] -1 disapprove with the reason &gt;&gt; &gt;&gt; &gt;&gt;
> Checklist for reference:
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] Download links are valid.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] Checksums and PGP signatures are valid.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] DISCLAIMER is included.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] Source code artifacts have correct names matching the
> current release.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] LICENSE and NOTICE files are correct for each
> ShardingSphere repo.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] All files have license headers if necessary.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; [ ] No compiled archives bundled in source archive.
> &gt;&gt;
> &gt;&gt;
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; Best wishes,
> &gt;&gt; Trista
> &gt;&gt;
> &gt;&gt;
> &gt;&gt;&nbsp; Juan Pan
> &gt;&gt;
> &gt;&gt;
> &gt;&gt; panj...@apache.org
> &gt;&gt; Juan Pan(Trista), Apache ShardingSphere &gt;&gt; &gt;&gt;
>
>
>
> --
> Zhang Yonglun
> Apache ShardingSphere
>
>
>
> --
> Zhang Yonglun
> Apache ShardingSphere
>
>

Reply via email to