> +1, >Looks good to me. > I checked: > > [X] Download links are valid. > [X] Checksums and PGP signatures are valid. > [X] DISCLAIMER is included. > [X] Source code artifacts have correct names matching the current release. > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. > [X] All files have license headers if necessary. > [X] No compiled archives bundled in source archive.
Chen QingYang <chenqingy...@apache.org> 于2019年11月13日周三 下午3:59写道: > +1, > > I checked: > > [X] Download links are valid. > [X] Checksums and PGP signatures are valid. > [X] DISCLAIMER is included. > [X] Source code artifacts have correct names matching the current release. > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. > [X] All files have license headers if necessary. > [X] No compiled archives bundled in source archive. > > sunbufu <sunb...@apache.org> 于2019年11月13日周三 下午2:34写道: > > > LGTM. > > > > > > +1, > > > > I checked: > > > > [X] Download links are valid. > > [X] Checksums and PGP signatures are valid. > > [X] DISCLAIMER is included. > > [X] Source code artifacts have correct names matching the current > release. > > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. > > [X] All files have license headers if necessary. > > [X] No compiled archives bundled in source archive. > > | | > > sunbufu > > | > > | > > 邮箱:sunyoub...@163.com > > email:sunb...@apache.com > > | > > > > > > On 11/13/2019 14:00,duhongjun<codefa...@163.com> wrote: > > +1, > > > > I checked: > > > > [X] Download links are valid. > > [X] Checksums and PGP signatures are valid. > > [X] DISCLAIMER is included. > > [X] Source code artifacts have correct names matching the current > release. > > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. > > [X] All files have license headers if necessary. > > [X] No compiled archives bundled in source archive. > > > > > > > > > > -- > > > > --------------------------------- > > > > HongJun Du > > Apache ShardingSphere > > > > > > > > At 2019-11-11 18:40:26, "Juan Pan" <panj...@apache.org> wrote: > > Hi everyone, > > > > > > With the help and effort of our community, the previous issues were fixed > > already. I am glad to invite everyone to move on to check and vote for > our > > 4.0.0-RC3 ROUND 4. > > > > > > Release notes: > > > > > https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md > > > > > > The release candidates: > > > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/ > > > > > > Maven 2 staging repository: > > > > > https://repository.apache.org/content/repositories/orgapacheshardingsphere-1027/org/apache/shardingsphere/ > > > > > > Git tag for the release: > > https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/ > > > > > > Release Commit ID: > > > > > https://github.com/apache/incubator-shardingsphere/commit/78a67e8c088ffc0b6f0e2c7418b0217cdc3bb87d > > > > > > Keys to verify the Release Candidate: > > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS > > > > > > Look at here for how to verify this release candidate: > > https://shardingsphere.apache.org/community/en/contribute/release/ > > > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > [ ] DISCLAIMER is included. > > > > > > [ ] Source code artifacts have correct names matching the current > release. > > > > > > [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo. > > > > > > [ ] All files have license headers if necessary. > > > > > > [ ] No compiled archives bundled in source archive. > > > > > > > > > > Best wishes, > > Trista > > > > > > Juan Pan > > > > > > panj...@apache.org > > Juan Pan(Trista), Apache ShardingSphere > > > > > > -- > Chen QingYang > Apache ShardingSphere >