Juan Pan <[email protected]>于2019年12月1日 周日下午5:46写道：
> Hi Sheng, > > > Considering some instrumental API of ShardingSphere were changed in > 4.0.0-RC3, ISSUE[1] is needed to put on the agenda, which depends on > Yonglun’s planning. > Besides, it would be efficient if Yonglun could take charge of ISSUE[2] > and ISSUE[3] since the ShardingSphere plugin for Skywalking is contributed > by him. However i’d like to listen to his thoughts. Let’s wait for his reply. > > > BTW, a nonstandard LICENSE has been used for ShardingSphere since > 4.0.0-RC3, do you think it is supposed to syncit to SW? Thank you for the remind. Two parts, ShardingSphere could be involved. 1. ShardingSphere plugin. It is just compiling level dependency, so, it just requires ShardingSphere jar is available in Maven Central, and as Apache release. SkyWalking is good, no need to add any license to SkyWalking repo. 2. ShardingSphere for SkyWalking backend storage. I think this part is not ready, and 100% bases on your plan. If ShardingSphere jar will be re-distributed in SkyWalking tar, then, YES, we need LICENSE update. If we are going to use ShardingSphere proxy, which I like more, then no LICENSE update too. > > > > [1] https://github.com/apache/skywalking/issues/3777 > [2] https://github.com/apache/skywalking/issues/3583 > [3]https://github.com/apache/skywalking/issues/3984 > [4] https://github.com/apache/incubator-shardingsphere/blob/dev/LICENSE > > > Juan Pan > > > [email protected] > Juan Pan(Trista), Apache ShardingSphere > > > On 12/1/2019 15:46，Sheng Wu<[email protected]> wrote： > Hi ShardingSphere community, especially for Yonglun, Juan > > The ShardingSphere internal APIs related to instrumentation have been > changed in RC3, so this issue[1] created to track the progress. Could > anyone sync to me, what is status? And what is the ETA? Including > 1. ShardingSphere plugin needs to move into the current test framework as > step 1[2] > 2. A high possibility of ShardingSphere plugin bug[3] requires the > feedback. Does ShardingSphere community know anything about this one? This > is not likely a SkyWalking bug. > > [1] https://github.com/apache/skywalking/issues/3777 > [2] https://github.com/apache/skywalking/issues/3583 > [3] https://github.com/apache/skywalking/issues/3984 > > > Sheng Wu 吴晟 > Twitter, wusheng1108 > -- Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108
