Hi Liang, Yes, you are right, fixed. I have also double checked all files to make sure there are no more problems now.
-- Zhang Yonglun Apache ShardingSphere zhangli...@apache.org <zhangli...@apache.org> 于2020年2月27日周四 上午12:01写道： > Hi, Yonglun > > I still find apache website url in OpenSharding repo[1], we should remove > them too. > > [1] > https://github.com/OpenSharding/opensharding-spi-impl/blob/master/pom.xml > > ------------------ > > Liang Zhang (John) > Apache ShardingSphere & Dubbo > > > Zhang Yonglun <zhangyong...@apache.org> 于2020年2月26日周三 下午11:18写道： > > > Hi Justin, > > > > Are you changing code to the package "io.opensharding" inside the project > > > or outside of it? I'm unclear what you are changing here. > > > > > > We changed the package name inside the project via the commit > > > > > https://github.com/OpenSharding/opensharding-spi-impl/commit/b2db2c2ef131551ca7ee898794a13a835260182c > > > > and > > > > > https://github.com/OpenSharding/opensharding-spi-impl-example/commit/e906fa292364a2229bf18930462363c0a8d30bb5 > > . > > > > -- > > > > Zhang Yonglun > > Apache ShardingSphere > > > > > > Justin Mclean <jmcl...@apache.org> 于2020年2月26日周三 下午4:39写道： > > > > > Hi, > > > > > > > The 3 projects are ALv2, but some dependencies include LGPL (for > > example: > > > > hibernate[1]), and some similar codes (about SQL revert) are patent > > > > declared by other company, we cannot make decision merge or not for > > now. > > > > > > It might be best if they make that clear and that they contain things > > that > > > are not compatible with the apache license. > > > > > > > > > > > And I still don't see why you would change package name to > > > > "io.opensharding" that does imply a relationship between these two > > > projects. > > > > > > Are you changing code to the package "io.opensharding" inside the > project > > > or outside of it? I'm unclear what you are changing here. > > > > > > Thanks, > > > Justin > > > > > >
