@Hongwei OK, after you submit the pull request, I will help you sign the ICLA.
------------------ Sincerely, Liang Zhang (John) Apache ShardingSphere Hongwei Li <[email protected]> 于2020年9月8日周二 下午12:23写道： > No. > Can you help me on the ICLA? > > Thanks, > Hongwei > > On Tue, Sep 8, 2020 at 12:08 AM [email protected] < > [email protected]> > wrote: > > > @HongWei Welcome, I just assign the issue[1] to you. > > > > By the way, there are big changes on this pr, do you assign the ICLA > > before? > > > > [1] https://github.com/apache/shardingsphere/issues/7307 > > > > ------------------ > > > > Sincerely, > > Liang Zhang (John) > > Apache ShardingSphere > > > > > > Hongwei Li <[email protected]> 于2020年9月8日周二 上午3:52写道： > > > > > Agreed! > > > I will open an issue. If you don't mind, I can work on the change. > > > > > > Thanks, > > > Hongwei > > > > > > On Mon, Sep 7, 2020 at 1:52 AM [email protected] < > > > [email protected]> > > > wrote: > > > > > > > primary and replica is better. > > > > The secondary data source cannot explain db should copy data to this > > data > > > > source. > > > > > > > > ------------------ > > > > > > > > Sincerely, > > > > Liang Zhang (John) > > > > Apache ShardingSphere > > > > > > > > > > > > [email protected] <[email protected]> 于2020年9月7日周一 下午1:47写道： > > > > > > > > > +1, primary data source is better than source data source, I prefer > > > this > > > > > one. > > > > > > > > > > ------------------ > > > > > > > > > > Sincerely, > > > > > Liang Zhang (John) > > > > > Apache ShardingSphere > > > > > > > > > > > > > > > Hongwei Li <[email protected]> 于2020年9月7日周一 上午11:04写道： > > > > > > > > > >> I saw the movement of replacing Master/Slave, even single word > > > 'master' > > > > or > > > > >> 'slave' in industry. > > > > >> > > > > >> One option which is used a lot is primary/secondary. > > > > >> Primary and replica are also reasonable terms to describe > > distributed > > > > >> databases. > > > > >> > > > > >> Personally I like 'primary' more than 'source' as the alternative > of > > > > >> 'master', if MySQL is not the only case. > > > > >> Take the below sentence as an example. > > > > >> > > > > >> (1) Judge primary data source visited in current thread. > > > > >> (2) Judge source data source visited in current thread. > > > > >> > > > > >> The first one makes more sense than the second. > > > > >> > > > > >> Conductor/Member is also seen as the alternative. But I don't > think > > it > > > > is > > > > >> a > > > > >> good choice for databases. > > > > >> > > > > >> Just my 2 cents > > > > >> > > > > >> BR, > > > > >> Hongwei > > > > >> > > > > >> > > > > >> On Sun, Sep 6, 2020 at 5:43 AM [email protected] < > > > > >> [email protected]> > > > > >> wrote: > > > > >> > > > > >> > Hi All, > > > > >> > > > > > >> > I want to discuss to rename MasterSlave module to ReadWriteSplit > > > > module. > > > > >> > > > > > >> > MySQL[1] has already change the master and slave to source and > > > > replica. > > > > >> > > > > > >> > Some concepts I plan to change: > > > > >> > > > > > >> > MasterSlave -> ReadWriteSplit > > > > >> > MasterDataSource -> SourceDataSource > > > > >> > SlaveDataSource -> ReplicaDataSource > > > > >> > > > > > >> > Please advice me. > > > > >> > > > > > >> > [1] > https://mysqlhighavailability.com/mysql-terminology-updates/ > > > > >> > > > > > >> > ------------------ > > > > >> > > > > > >> > Sincerely, > > > > >> > Liang Zhang (John) > > > > >> > Apache ShardingSphere > > > > >> > > > > > >> > > > > > > > > > > > > > > >
