+1,

I checked:

[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] Source code distributions have correct names matching the current
release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license headers if necessary.
[X] No compiled archives bundled in source archive.

But I still find some problems, there are:

1. Year of NOTICE is 2020, need to update 2021;
2. The new lib of calcite and their dependencies do not add into LICENSE
file, but the license compatibilit
<http://www.baidu.com/link?url=1J66nsl93GKYItu2oDRFdO783tbhweINXwQWZJKc464TDu3navgK9t0QkPrcDxi94PUoPTf1mnIOhenJhH-MPF-sI62AWEP5W_SGN9J-SDW>ies
are
valid.

The problems are not major, I will submit pull requests to fix them.


------------------

Sincerely,
Liang Zhang (John)
Apache ShardingSphere



Zhang Yonglun <zhangyong...@apache.org> 于2021年6月15日周二 上午11:47写道:

> Kindly reminder, please list what you have checked before vote.
>
> --
>
> Zhang Yonglun
> Apache ShenYu (Incubating)
> Apache ShardingSphere
>
>
> Juan Pan <panj...@apache.org> 于2021年6月13日周日 下午1:21写道:
>
> > Hello ShardingSphere Community,
> >
> >
> > This is a call for vote to release Apache ShardingSphere version
> 5.0.0-beta
> >
> >
> > Release notes:
> > https://github.com/apache/shardingsphere/blob/master/RELEASE-NOTES.md
> >
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/shardingsphere/5.0.0-beta/
> >
> >
> > Maven 2 staging repository:
> >
> >
> https://repository.apache.org/content/repositories/orgapacheshardingsphere-1061/org/apache/shardingsphere/
> >
> >
> > Git tag for the release:
> > https://github.com/apache/shardingsphere/tree/5.0.0-beta/
> >
> >
> > Release Commit ID:
> >
> >
> https://github.com/apache/shardingsphere/commit/9bb3dfd975c88344786e86c2a712fec218085bbc
> >
> >
> > Keys to verify the Release Candidate:
> > https://dist.apache.org/repos/dist/dev/shardingsphere/KEYS
> >
> >
> > Look at here for how to verify this release candidate:
> > https://shardingsphere.apache.org/community/en/contribute/release/
> >
> >
> > GPG user ID:
> > panjuan
> >
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> >
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> > PMC vote is +1 binding, all others is +1 non-binding.
> >
> >
> > Checklist for reference:
> >
> >
> > [ ] Download links are valid.
> >
> >
> > [ ] Checksums and PGP signatures are valid.
> >
> >
> > [ ] Source code distributions have correct names matching the current
> > release.
> >
> >
> > [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> >
> >
> > [ ] All files have license headers if necessary.
> >
> >
> > [ ] No compiled archives bundled in source archive.
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Juan Pan(Trista), Apache ShardingSphere PMC
> > Twitter, @trista86934690
> >
> >
>

Reply via email to