+1 from me.
------------------------------------------------------------------------------ Juan Pan(Trista), Apache ShardingSphere PMC Twitter, @trista86934690 On 07/11/2021 19:05，吴伟杰<wuwei...@apache.org> wrote： Hi Consider the 3.x is a GA release, and the plugins for 4.x RC are no longer needed because there are already plugins for 4.x GA. Our primary conclusion is removing the following plugins: 1. sharding-jdbc-1.5.x-plugin 2. sharding-sphere-4.x-rc3-plugin 3. sharding-sphere-4.x-plugin (This is for RC1 and RC2) If no one objects, I will clear up the codebase next weekend. ------------------ Sincerely, Weijie Wu (TeslaCN) Apache ShardingSphere Sheng Wu <wu.sheng.841...@gmail.com> 于2021年7月11日周日 上午9:12写道： Hi Do we have a conclusion? And Weijie, could you follow this and clear up the codebase? Sheng Wu 吴晟 Twitter, wusheng1108 Juan Pan <panj...@apache.org> 于2021年7月1日周四 上午9:11写道： Hi, I have no clear idea on how each plugin is different, but they are actually different. Considering users' preference for different releases,My +1 to keep the 4.0 and 4.1 GA versions. ------------------------------------------------------------------------------ Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC Twitter, @trista86934690 On 07/1/2021 07:50，Sheng Wu<wu.sheng.841...@gmail.com> wrote： Hi ``` 3. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin 4. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin 5. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin 6. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin ``` What is the difference between 4.x and 4.0/4.1 plugins? Could some of them be removed? And RC3 should be removed as you have plugins for GA releases already. Sheng Wu 吴晟 Twitter, wusheng1108 吴伟杰 <wuwei...@apache.org> 于2021年6月30日周三 下午11:19写道： Hi All, SkyWalking's master branch hosts 7 agent plugins for different versions of ShardingSphere. They think the plugins are too many. ( https://github.com/apache/skywalking/pull/7171#issuecomment-868353013) Here is the list: 1. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin 2. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin 3. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin 4. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin 5. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin 6. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin 7. https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer been maintained, I propose to remove sharding-jdbc-1.5.x-plugin < https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin and sharding-sphere-3.x-plugin < https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin from SkyWalking's master branch to reduce maintenance costs. ------------------ Sincerely, Weijie Wu (TeslaCN) Apache ShardingSphere
