Hello, +1 binding But some suggestions for next time, 1. Remove the license of ShardingSphere from charts package since there is no relevant file references. 2. Add the license of zookeeper chats, which is Apache 2 license but doesn’t mention them in license file of charts package 3. As the version of chats is independent from ShardingSphere, its package name is better to be `apache-shardingsphere-proxy-chart-1.1.0.tgz`
Best, Trista ------------------------------------------------------------------------------ Trista Pan Twitter & Github: tristaZero On 06/14/2022 00:11，吴伟杰<wuwei...@apache.org> wrote： Hello ShardingSphere Community, This is a call for vote to release Apache ShardingSphere version 5.1.2 [Round 3]. Release notes: https://github.com/apache/shardingsphere/blob/5.1.2/RELEASE-NOTES.md The release candidates: https://dist.apache.org/repos/dist/dev/shardingsphere/5.1.2/ Maven 2 staging repository: https://repository.apache.org/content/repositories/orgapacheshardingsphere-1087/org/apache/shardingsphere/ Git tag for the release: https://github.com/apache/shardingsphere/tree/5.1.2/ Release Commit ID: https://github.com/apache/shardingsphere/commit/97d0d59ebd3a68612aad20896d1bc31f7d222283 Keys to verify the Release Candidate: https://dist.apache.org/repos/dist/dev/shardingsphere/KEYS Look here for how to verify this release candidate: https://shardingsphere.apache.org/community/en/contribute/release/ GPG key ID: 55C1A242B0F517C4 The vote will be open for at least 72 hours or until the necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason PMC vote is +1 binding, all others are +1 non-binding. Checklist for reference: [ ] Download links are valid. [ ] Checksums and PGP signatures are valid. [ ] Source code distributions have correct names matching the current release. [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo. [ ] All files have license headers if necessary. [ ] No compiled archives bundled in source archive. Regards, Weijie ----------------------------------------------- Weijie Wu 吴伟杰 Apache ShardingSphere PMC GitHub@TeslaCN
