+1, independent tests are very important with separate sub project/module.
-- Kimm King(kimmk...@apache.org/kimmk...@163.com) Apache Dubbo&ShardingSphere PMC Member github&twitter: kimmking At 2023-06-26 20:40:14, "zhangli...@apache.org" <zhangli...@apache.org> wrote: >+1. >The kernel of ShardingSphere is becoming heavier with more and more >features and plugins. >I also hope to move the extensions from the core project into other >extension projects. >It is better to use E2E tests in extension projects to solve the >compatibilitable issues effectively. > >------------------ > >Sincerely, >Liang Zhang (John) >Apache ShardingSphere > > >Zhengqiang Duan <duanzhengqi...@apache.org> 于2023年6月26日周一 20:07写道： > >> Thank you for your feedback, Zheng. >> >> I think `shardingsphere-plugin` repository needs to be released >> synchronously with shardingsphere. Regarding compatibility, the spi >> interface of shardingsphere does not change frequently. If there is a >> change, the submitter needs to update these implementations of the >> `shardingsphere-plugin` repository synchronously. >> >> Best regards, >> Zhengqiang >> —————————————————————— >> Zhengqiang Duan (duanzhengqi...@apache.org) >> Apache ShardingSphere PMC >> GitHub@strongduanmu >> >> >> Zheng Feng <zh.f...@gmail.com> 于2023年6月26日周一 20:03写道： >> >> > It looks good but how about shardingsphere-plugin release cycle? is it >> the >> > same with shardingsphere? and who will be responsible for the maintenance >> > and compatibility? >> > >> > Regards, >> > Zheng Feng >> > >> > Zhengqiang Duan <duanzhengqi...@apache.org> 于2023年6月26日周一 19:46写道： >> > >> > > Hi community, >> > > >> > > Due to the rapid development of ShardingSphere, plugin submodules are >> > > currently extracted from both sharding and encrypt modules to store >> some >> > > special algorithms contributed by the community, such as cosId, nanoid >> > > sharding >> > > algorithm, and sm3 and sm4 encryption algorithms. These plugins enrich >> > the >> > > applicable scenarios of ShardingSphere, but also make ShardingSphere >> > > bloated and complicated. >> > > >> > > . >> > > ├── encrypt >> > > │ ├── api >> > > │ ├── core >> > > │ ├── distsql >> > > │ └── plugin >> > > └── sharding >> > > ├── api >> > > ├── core >> > > ├── distsql >> > > └── plugin >> > > >> > > In order to reduce the dependence on some special jar packages, such >> as: >> > > cosid, bcprov-jdk15on, we can move the code in the plugin to an >> > independent >> > > shardingsphere-plugin repository, and community contributors can >> > contribute >> > > more algorithm implementations in this repository. >> > > >> > > When users want to use the algorithm in shardingsphere-plugin >> repository, >> > > they only need to package the algorithm and add the jar to >> > ShardingSphere. >> > > >> > > Considering that this task will take some time to apply for a new >> > > repository, I suggest implementing it in two stages as follows: >> > > >> > > - first, remove plugin document in ShardingSphere >> > > - second, move plugin code and document to shardingsphere-plugin >> > > repository >> > > >> > > Everyone is welcome to participate in the discussion and express their >> > > views. Thank you. >> > > >> > > For more details, you can also refer github issue - >> > > https://github.com/apache/shardingsphere/issues/26590. >> > > >> > > Best regards, >> > > Zhengqiang >> > > —————————————————————— >> > > Zhengqiang Duan (duanzhengqi...@apache.org) >> > > Apache ShardingSphere PMC >> > > GitHub@strongduanmu >> > > >> > >>
