in org.apache.shenyu.plugin.apache.dubbo.cache.ApplicationConfigCache and 
ApplicationConfigCache in other RPC plugin
------------------------------------------------------------------------------------------------
private final LoadingCache<> cache = CacheBuilder.newBuilder()                  
                                                                      
.maximumWeight(maxCount)                                                        
                                
.weigher( (string, referenceConfig) -> getSize())                               
                                                         
.build();

private int getSize() {      
return (int) cache.size();
}
------------------------------------------------------------------------------------------------

Here, weight is used to control the total capacity of guava cache, but the 
weight of each cache use getSize,it represents the total number of items cached 
when a piece of data is cached.
I think there may be wrong usage here, If we use weights, the weights should 
represent the size of each piece of data, so here should be replaced by the 
number of bars to control the total capacity

------------------ ???????? ------------------??????:                           
                                                                                
             "dev"                                                              
                      <[email protected]>;????????: 2021??5??17??(??????) 
????3:43??????: "dev"<[email protected]>;????: Re: There may be a wrong way 
to use guava cacheHi Zhen,Please send the raw text to this mail list.--Zhang 
YonglunApache ShenYu (Incubating)Apache ShardingSpherettttangzhen 
<[email protected]> ??2021??5??17?????? ????3:37??????> in 
org.apache.shenyu.plugin.apache.dubbo.cache.ApplicationConfigCache and> 
ApplicationConfigCache in other RPC plugin>>> 
------------------------------------------------------------------------------------------------>
 private final LoadingCache<&gt; cache => 
CacheBuilder.newBuilder()&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;>>
 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;>
 
.maximumWeight(maxCount)&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;>>
 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;>
 .weigher( (string, referenceConfig) -&gt;> 
getSize())&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;>> 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;>
 .build();> private int getSize() {&nbsp;&nbsp;&nbsp;> &nbsp;&nbsp;&nbsp; 
return (int) cache.size();> }>> 
------------------------------------------------------------------------------------------------>>
 Here, weight is used to control the total capacity of guava cache, but the> 
weight of each cache use getSize,it represents the total number of items> 
cached when a piece of data is cached.> I think there may be wrong usage here, 
If we use weights, the weights> should represent the size of each piece of 
data, so here should be replaced> by the number of bars to control the total 
capacity

Reply via email to