ok i will review~ thanks
haiqi qin <[email protected]> 于2022年1月11日周二 00:05写道： > > I think you're right. So I modified the other code using the stream. > If correct, I hope you can agree.about ldapconfiguration by QinHaiqi · Pull > Request #2746 · apache/incubator-shenyu (github.com) > <https://github.com/apache/incubator-shenyu/pull/2746> > > XiaoYu <[email protected]> 于2022年1月9日周日 23:43写道： > > > When the object is null how should it be handled, of course you are > > welcome to optimize > > thanks > > > > XiaoYu <[email protected]> 于2022年1月9日周日 23:43写道： > > > > > > I don't think it's necessary to use option in this place.If null, the > > > default value is null.Can I optimize and remove optional. > > > > > > 秦海棋 <[email protected]> 于2022年1月9日周日 22:51写道： > > > > > > > > > > https://github.com/apache/incubator-shenyu/blob/6475ba29da14bb808116e4d813c9608ef72fb665/shenyu-admin/src/main/java/org/apache/shenyu/admin/model/entity/DataPermissionDO.java#L129 > > > > > > > > I don't think it's necessary to use option in this place.If null, the > > > > default value is null.Can I optimize and remove optional. > >
