Thanks Yu, resolved. And I saw you’ve merged it. 😊 Thanks, Han
From: XiaoYu <[email protected]> Date: Thursday, March 3, 2022 at 15:42 To: [email protected] <[email protected]> Subject: Re: [DISCUSS] Support redirecting to external URI instead of the URIs in bootstrap hi， I already review pr. please note some minor maybe changes. thanks~ Han Gao <[email protected]> 于2022年3月3日周四 15:01写道： > > Thanks Yu! here is the PR, > https://github.com/apache/incubator-shenyu/pull/2968. > > Thanks, > Han > > From: XiaoYu <[email protected]> > Date: Thursday, March 3, 2022 at 14:10 > To: [email protected] <[email protected]> > Subject: Re: [DISCUSS] Support redirecting to external URI instead of the > URIs in bootstrap > hi Han Gao > > great, looking forward to your pr > > Han Gao <[email protected]> 于2022年3月3日周四 13:00写道： > > > Hi all, > > > > > > > > As describe in https://github.com/apache/incubator-shenyu/issues/2966. > > Currently when setting the fallback URI to external URIs, including > > registered APIs, it doesn’t work and will return 404 when circuit breaking. > > And it only works for URIs in the bootstrap(gateway). Below are 2 examples. > > > > > > > > Setting `https://example.com/` <https://example.com/> as fallback URI, > > which is an external URI, it will return 404. > > > > > > > > Setting `http://localhost:9195/shenyu/plugin/findByName?name=sentinel` > > <http://localhost:9195/shenyu/plugin/findByName?name=sentinel> as > > fallback URI, which is an API in bootstrap, it works. > > > > > > > > My suggestion is not only support fallback URIs in bootstrap, but also for > > external URIs. Below is an example for setting `https://example.com/` > > <https://example.com/> as fallback URI after supporting external URIs. > > > > > > > > Please let me know if any comment or suggestion. > > > > > > > > Thanks, > > > > Han > > > > > >
