hi i reveiw this pr， I have 2 suggestions
1. add asf license to file header ，like this #### /* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ ### 2. Remove code generated by some open source tools （such as ShenyuClient.sln ， .editConfig） Han G <dhan...@hotmail.com> 于2022年4月19日周二 09:46写道： > > Thanks Yu! I saw the name has been changed. And I’ve created a PR, > https://github.com/apache/incubator-shenyu-client-dotnet/pull/1. > > Please help to review and feel free leave comment. Thanks a lot! > > Thanks, > Han > > > From: XiaoYu <xia...@apache.org> > Date: Monday, April 18, 2022 at 20:13 > To: dev@shenyu.apache.org <dev@shenyu.apache.org> > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > hi > > ok， its mean `dotnet`，i will changed this repo name > > Han G <dhan...@hotmail.com> 于2022年4月18日周一 19:32写道： > > > > Hi Yu, so quick action! Seems there is a typo in repo name. It should be > > `dotnet` instead of `donet`. :p > > > > Thanks, > > Han > > > > > > From: XiaoYu <xia...@apache.org> > > Date: Monday, April 18, 2022 at 18:25 > > To: dev@shenyu.apache.org <dev@shenyu.apache.org> > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > Hi Han G > > > > repo[1] it has been created up, do it, look forward to your contribution! > > > > [1]: https://github.com/apache/incubator-shenyu-client-donet > > > > thanks~ > > > > Han G <dhan...@hotmail.com> 于2022年4月18日周一 16:01写道： > > > > > > Thanks Yu, agree with your suggestion! Yes, I’m interested in this > > > proposal and has almost finished the code. Will create PR after the repo > > > has been created! > > > > > > Thanks, > > > Han > > > > > > > > > From: XiaoYu <xia...@apache.org> > > > Date: Monday, April 18, 2022 at 14:47 > > > To: dev@shenyu.apache.org <dev@shenyu.apache.org> > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > Hi Han G > > > > > > 1. i think this is better： > > > * Client: Apache.ShenYu.Client > > > * AspNetCore: Apache. ShenYu.AspNetCore > > > 2. if creater this repo，shenyu ppmc will notify you > > > > > > Very happy to see this proposal and look forward to your contribution > > > (if you are interested). > > > > > > thanks! > > > > > > Han G <dhan...@hotmail.com> 于2022年4月18日周一 14:16写道： > > > > > > > > Thanks Yu! Glad to see that it’s a good task! Please let me know once > > > > the repo has been created. And I can create PR to merge this code. > > > > > > > > BTW, here are the package name for `client` and `AspNetCore` packages > > > > in my mind, please let me know if any suggestion. > > > > > > > > * Client: Apache.Shenyu.Client > > > > * AspNetCore: Apache.Shenyu.AspNetCore > > > > > > > > After there is a conclusion for the package name, the next step is to > > > > create an official Nuget account and publish the packages. > > > > > > > > Here’re some examples you can refer. > > > > > > > > * https://www.nuget.org/packages?q=opentelemetry > > > > * https://www.nuget.org/packages?q=apache > > > > > > > > Thanks, > > > > Han > > > > > > > > > > > > From: XiaoYu <xia...@apache.org> > > > > Date: Monday, April 18, 2022 at 13:49 > > > > To: dev@shenyu.apache.org <dev@shenyu.apache.org> > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > HI > > > > > > > > I think this is a very good task and if you are interested, > > > > > > > > shenyu ppmc should create this repository : > > > > incubator-shenyu-client-donet > > > > > > > > Han G <dhan...@hotmail.com> 于2022年4月18日周一 10:11写道： > > > > > > > > > > Hi all, > > > > > > > > > > The dotnet SDK is ready, please help to review. > > > > > https://github.com/hgaol/incobator-shenyu-client-dotnet > > > > > > > > > > The next steps in my mind are, > > > > > > > > > > * Review the code. > > > > > * If it’s acceptable, discuss about the package name and register > > > > > in package center. There’re 2 packages - `client` and `AspNetCore`. > > > > > * Client package is web framework agnoistic, which is > > > > > responsible for sending the register requests to shenyu admin. > > > > > * AspNetCore is mainly for ASP.NET Core framework, depend on > > > > > the client package. > > > > > > > > > > Thanks a lot for your time! > > > > > > > > > > Thanks, > > > > > Han > > > > > > > > > > > > > > > From: 邪龙(dragon-zhang) <1936978...@qq.com.INVALID> > > > > > Date: Saturday, April 16, 2022 at 23:45 > > > > > To: dev <dev@shenyu.apache.org> > > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > > haha, sidecar is just in personal thoughts, if you also agreed with > > > > > sidecar, we can discuss with other language client developers. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------ Original ------------------ > > > > > From: Han G <dhan...@hotmail.com> > > > > > Date: Sat,Apr 16,2022 11:33 PM > > > > > To: dev@shenyu.apache.org <dev@shenyu.apache.org> > > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > > > > > > > > > > > > > > > > > Yes, agree with grpc! About sidecar, I’ve heard it but I’m not > > > > > familiar with it… I can go through it offline. > > > > > > > > > > Thanks, > > > > > Han > > > > > > > > > > > > > > > From: 邪龙(dragon-zhang) <1936978...@qq.com.INVALID> > > > > > Date: Saturday, April 16, 2022 at 23:20 > > > > > To: dev <dev@shenyu.apache.org> > > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > > Glad to hear that c# does not need to solve complex compatibility > > > > > problems, :). Your idea is good and maybe we can also put grpc in > > > > > second priority, shenyu now supports grpc well. Besides, in personal, > > > > > what do you think of sidecar? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------ Original ------------------ > > > > > From: Han G <dhan...@hotmail.com&gt; > > > > > Date: Sat,Apr 16,2022 10:50 PM > > > > > To: dev@shenyu.apache.org <dev@shenyu.apache.org&gt; > > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > > > > > > > > > > > > > > > > > .NET (Core) is cross-platform, the most famous web framework is > > > > > ASP.NET Core, we can support it first. > > > > > .NET framework is windows only, which is a legacy stack. And the > > > > > related web framework is ASP.NET. If needed, I think we can support > > > > > it in future release. > > > > > > > > > > Thanks, > > > > > Han > > > > > > > > > > > > > > > From: 邪龙(dragon-zhang) <1936978...@qq.com.INVALID&gt; > > > > > Date: Saturday, April 16, 2022 at 22:41 > > > > > To: dev <dev@shenyu.apache.org&gt; > > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > > That's a good idea. I'm not sure if the compatibility of different > > > > > systems and CPU architectures is a problem for c#? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------ Original ------------------ > > > > > From: Han G <dhan...@hotmail.com&amp;gt; > > > > > Date: Sat,Apr 16,2022 10:14 PM > > > > > To: dev <dev@shenyu.apache.org&amp;gt; > > > > > Subject: Re: [PROPOSAL] add incubator-shenyu-client-dotnet > > > > > > > > > > > > > > > > > > > > Hi folks, > > > > > > > > > > I’d like to implement a dotnet (C#) client for Shenyu. The behavior > > > > > will be similar like the Shenyu java client. Please let me know if > > > > > any suggestion or comment. Thanks a lot! > > > > > > > > > > Thanks, > > > > > Han
