Hi good job, i will review
何 凤恩 <hefen...@hotmail.com> 于2022年5月31日周二 11:50写道: > > Hi, community > I have upgraded springboot from 2.2.2-Release to 2.6.8 of shenyu.but after > upgrade. It’s nessary to deal upgrade question, major question as follow: > > 0. dealed question: > > a) fix deprecated methods. > > b) optimize pom.xml of shenyu,shenyu-bootstrap,shenyu-admin > > c) support springcloud loadbalancer and support ribbon by your self. > > d) optimize some test cases. > > e) fix some bug of upgrade. > > > 1. Need Optimiezed Question: > > a) * Build http server logic of ShenyuNettyWebServerConfiguration.java > need to optimize. I will fix it in next pr. > > b) * In reactor-netty, it romve elastic and fixed http connection pool. > So, Shenyu http connection just support fixed connection pool in short > period. If reactor-netty release new version, I will add new feature to > support elastic connection pool. > > > > 2. Need Fix Bug And Question > > a) shenyu-example-grpc can't execute in my local enviroment. > > b) shenyu-example-spring-cloud-dubbo-example can execute but result not > right. I will fix it in next pr. > > c) shenyu-example-sofa's example is error. I have disscuss with > @Likeguo, he also can’t execute. > > d) shenyu-exmaple-tars's exmaple is error. I have disscuess with > @Likeguo.but no result. > > e) other plugins, I have test. It’s over. > > I have submit my pull request, please see pr#3438. > > Best Regards!