Hi this good idea. itmerged into master.
Thanks. Han G <dhan...@hotmail.com> 于2022年6月16日周四 18:15写道： > > Hi folks, I’ve finished the curator downgrade task. Here’s the PR, please > help to review, thanks for your time! > > https://github.com/apache/incubator-shenyu/pull/3569. > > Finally, considering 4.3.0 is more stable, I changed to curator 4.3.0. I’ve > tested with sofa example, and it works well. More details can refer to the > PR. Thanks! > > Thanks, > Han > > > From: Han G <dhan...@hotmail.com> > Date: Tuesday, June 14, 2022 at 16:04 > To: dev@shenyu.apache.org <dev@shenyu.apache.org> > Subject: Re: downgrade curator version to 4.0.1 > To unblock others who want to use sofa, adding back curator dependency ver > 4.0.1 in bootstrap in first step. PR link, > https://github.com/apache/incubator-shenyu/pull/3557. > > Please help to review and feel free to leave comment. > > Thanks, > Han > > > From: Han G <dhan...@hotmail.com> > Date: Tuesday, June 14, 2022 at 15:33 > To: dev <dev@shenyu.apache.org> > Subject: downgrade curator version to 4.0.1 > Hi folks, > > Due to the Curator version incompatible issue in bootstrap. E.g. sofa is > compatible with ver 4.x but bootstrap is using 5.x. More details can refer to > https://github.com/apache/incubator-shenyu/issues/3461. > > The current work around is to add curator 4.0.1 dependency in bootstrap and > using classes/methods both existed in 5.x and 4.x in curator. > > I plan to downgrade to version 4.0.1, because this version has been tested > works well for sofa/dubbo/motan/tars. I created an task issue below to track > it, https://github.com/apache/incubator-shenyu/issues/3556. > > Please let me know if any suggestion or comment. Thanks! > > Thanks, > Han
