Aias00 commented on code in PR #5:
URL: https://github.com/apache/shenyu-plugin-store/pull/5#discussion_r4216790197
##########
pom.xml:
##########
@@ -64,6 +64,9 @@
<properties>
<java.version>17</java.version>
+ <shenyu.version>2.7.0</shenyu.version>
Review Comment:
[NIT] shenyu.version is pinned to 2.7.0 while the store repo itself is
2.7.1-SNAPSHOT. Confirm 2.7.0 is the intended shenyu compatibility target (the
store plugins compile against the released shenyu 2.7.0 BOM). If store is meant
to track shenyu 2.7.1, bump this to 2.7.1.
##########
shenyu-spring-boot-starter-plugin/pom.xml:
##########
@@ -30,5 +30,25 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
+ <modules>
+ <module>shenyu-spring-boot-starter-plugin-motan</module>
+ <module>shenyu-spring-boot-starter-plugin-tars</module>
+ </modules>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-autoconfigure</artifactId>
Review Comment:
[NIT] spring-boot-autoconfigure is declared as a compile dependency on the
aggregator (lines 37-52), so it is inherited by the motan/tars starter
submodules. It works because the shenyu 2.7.0 BOM imports
spring-boot-dependencies (version is managed), but these starter-specific deps
read cleaner if declared in each individual starter module rather than the
aggregator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
