IMO we should return 500 when there's an Exception within the fetcher, but 504 when translating this to Shindig-emitted status codes, such as here.
Could you help clean this up in your already-open BasicHttpFetcher cleanup CL? Thanks, John On Wed, Feb 10, 2010 at 2:17 PM, <[email protected]> wrote: > LGTM > > > > http://codereview.appspot.com/207059/diff/1/14 > File > > > java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java > (right): > > http://codereview.appspot.com/207059/diff/1/14#newcode134 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java:134: > response.getHttpStatusCode()); > If the external system return 500, should we as well? > maybe 504? > > > http://codereview.appspot.com/207059/show >
