Rietveld is giving me all sorts of problems, so I'll paste my comments here.
1. [extremely minor] Rename gmodules.com to apache.org or example.com in tests. 2. Does the new HttpFetcher pipeline work when StringUtils.isEmpty(uri.getScheme()) ie. for schemaless requests? I'd be interested in a quick test. Past that, it's looking great. I'll apply ASAP after hearing about #2. --j On Wed, Feb 10, 2010 at 4:28 PM, <[email protected]> wrote: > Last change separate shindig error (Exception) from external error > (error respond) in the fetcher. > Also it handle error code of "internal error" from external system, and > convert to gateway error before sending to user. > > The point is that we will be able to track in our log what are really > shindig errors verses external system errors. > > > > > http://codereview.appspot.com/206057/show >
