Code looks fine - just a few small requested tweaks.

http://codereview.appspot.com/207091/diff/1/8
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java
(right):

http://codereview.appspot.com/207091/diff/1/8#newcode92
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java:92:
Log.info("Bad TTL value '" + ttlStr + "' was ignored");
Looks like IDE creep here -- could you switch this to the typical style
(Logger log = Logger.getLogger(clazz);)?

http://codereview.appspot.com/207091/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java
(right):

http://codereview.appspot.com/207091/diff/1/2#newcode209
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java:209:
// a content type like text/html which unfortunately happens all too
often
odd, chunk mismatch error in this file. Try syncing and re-sending the
patch.

http://codereview.appspot.com/207091/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
(right):

http://codereview.appspot.com/207091/diff/1/3#newcode180
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:180:
// Use a 'Vary' style check on the response
same

http://codereview.appspot.com/207091/show

Reply via email to