Seems sensible to me. Added logic to accommodate this along w/ a new test, and committed. Thanks!
On Mon, Feb 22, 2010 at 9:52 AM, <[email protected]> wrote: > > http://codereview.appspot.com/217074/diff/1/3 > File > > java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java > (right): > > http://codereview.appspot.com/217074/diff/1/3#newcode68 > java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java:68: > (serverPort == 443 && "https".equals(scheme)) ? "" : > To be on the safe side, I will check also for port <=0 and don't specify > port (for some reason I remember seeing -1 when port is not specified). > > > http://codereview.appspot.com/217074/show >
