This change looks fine as-is, but I agree that a whitelist approach is preferable. I'd start with "text/*" as you mentioned. We might also want to pass Mime type to the encoding detector in such case as we want more fine-grained control over certain detection passes (eg. HTML-based).
On Thu, Feb 25, 2010 at 3:39 PM, <[email protected]> wrote: > This is the simple fix of just adding type to blacklist. > > Is it time to revisit this and run the encoding detector only on > text/html or text/* instead of using blacklist? > > > > > http://codereview.appspot.com/224064/show >
