LGTM

The more I read, the more I like the original interface LinkRewriter.
Maybe UriManager should at least implement the LinkRewriter interface?



http://codereview.appspot.com/223093/diff/1001/2002
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java
(right):

http://codereview.appspot.com/223093/diff/1001/2002#newcode152
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java:152:
rewriteUri(imageRewriter, uri, linkContext));
Maybe put rewrite function in ProxyUriManager that do what rewriteUri
does.

http://codereview.appspot.com/223093/show

Reply via email to