Good call, fixed, thx! On Fri, Mar 5, 2010 at 11:49 AM, <[email protected]> wrote:
> LGTM > > > http://codereview.appspot.com/224093/diff/2001/2003 > File > > > java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java > (right): > > http://codereview.appspot.com/224093/diff/2001/2003#newcode211 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java:211: > if (config.shouldRewriteURL(uri.getResource().toString())) { > Since you check for shouldRewriteUrl in line 67, do you really need to > check again? one of the check is redundant. > > > http://codereview.appspot.com/224093/show >
