LGTM

(Sorry previous mail didn't take comment...)


http://codereview.appspot.com/224094/diff/16001/17004
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingContentRewriter.java
(right):

http://codereview.appspot.com/224094/diff/16001/17004#newcode32
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingContentRewriter.java:32:
public class ProxyingContentRewriter extends DomWalker.Rewriter {
Just a suggestions, there a repeated boiler plate code for multiple
rewriters. Maybe it is possible to make it a generic that take in a
visitor class and a uri manager?

http://codereview.appspot.com/224094/show

Reply via email to