Thanks for all the feedback. I've addressed all by: 1. Adding default config values (set to false) in shindig.properties 2. Added documentation in shindig.properties with justification regarding strict parsing 3. Correspondingly changed @Inject'ed values to Strings, converted to Boolean via Boolean.parseBoolean(String)
Patch on the way. On Mon, Mar 15, 2010 at 10:22 PM, <[email protected]> wrote: > seems okay, should add some docs and rationale why this is needed and in > what situation. > > > > http://codereview.appspot.com/434044/show >
