On Tue, Mar 30, 2010 at 9:04 AM, Ziv Horesh <[email protected]> wrote:
> I started implementing using a map based. but it didn't look right to me > with some parameters saved directly and some as map. > I had to do more code to keep parameters in sync. Also the current code try > to validate each param, so keeping direct value seems appropriate. > Seems like a reasonable argument. I'll remove the setter for now and commit. Cheers, John > > But now that you mention it, I might still want to add a map, for what we > discussed as a service that support experimental params. > > > On Mon, Mar 29, 2010 at 11:19 PM, <[email protected]> wrote: > >> The strategy generally looks good, though I admit the preponderance of >> query params starts calling into question a more general Map-based >> strategy. For the moment though, looks good. Thoughts? >> >> >> http://codereview.appspot.com/823042/diff/9001/10005 >> File >> >> >> java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java >> (right): >> >> http://codereview.appspot.com/823042/diff/9001/10005#newcode90 >> >> java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:90: >> public ProxyUri setFallbackUrl(String url) { >> unused? > > > All the set function are not really used at this point. They will be needed > for a proxy service that has more global API then just url. > > >> >> >> http://codereview.appspot.com/823042/show >> > >
