Yes I think we have a problem here. The concat servlet used the ProxyHandler to fetch the data, which also used the RequestRewriterRegistry to rewrite data. As part of the rewriters refactoring, the concat servlet does not use the ProxyHandler anymore, and as a result the rewriters are skipped. I am working on a patch for this.
Mat thanks for finding that out. -Ziv On Mon, Apr 12, 2010 at 1:10 AM, Mat Mannion <[email protected]> wrote: > The previous jars I was using were built from trunk on 2nd Feb at 9am > (from META-INF/maven/org.apache.shindig/{package}/pom.properties in > the src jar), so quite a large window unfortunately :( > > Mat > > On 12 April 2010 03:23, Paul Lindner <[email protected]> wrote: > > Hi Mat, > > > > Can you identify the version of trunk where it was working before? > > > > Ziv, you've been refactoring this code lately, any ideas? > > > > Thanks! > > > > On Thu, Apr 8, 2010 at 4:19 AM, Mat Mannion <[email protected]> > wrote: > > > >> Hi, > >> > >> We're currently developing a container based on (Java) Shindig trunk, > >> but I've noticed problems since I synced with the latest version from > >> trunk yesterday, where background images that are referenced as > >> relative to CSS files are no longer being rewritten. > >> > >> Stepping through the code in a debugger, it would appear that requests > >> that go through the concat servlet are no longer being rewritten (in > >> particular, the CssRequestRewriter is never called from execution of > >> the concat servlet). > >> > >> Is this a regression? I don't really follow check-ins so I'm not > >> entirely familiar with the codebase, but this seems to be something > >> that was working a couple of weeks ago but isn't now. > >> > >> Regards, > >> > >> Mat > >> > >> -- > >> Mat Mannion > >> Web Developer > >> e-lab, IT Services > >> University of Warwick > >> Coventry > >> CV4 7AL > >> > >> Tel: 024 765 74433 > >> Email: [email protected] > >> > > > > > > -- > Mat Mannion > Web Developer > e-lab, IT Services > University of Warwick > Coventry > CV4 7AL > > Tel: 024 765 74433 > Email: [email protected] >
