http://codereview.appspot.com/1032045/diff/6001/7001 File java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java (right):
http://codereview.appspot.com/1032045/diff/6001/7001#newcode130 java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java:130: return true; why not just return the matched callback param to encapsulate logic? http://codereview.appspot.com/1032045/diff/6001/7003 File java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java (right): http://codereview.appspot.com/1032045/diff/6001/7003#newcode86 java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java:86: if (!("GET".equals(method) || "POST".equals(method))) { can't this just be enforced by direct use? http://codereview.appspot.com/1032045/diff/6001/7003#newcode87 java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java:87: sendError(servletResponse, new ResponseItem(HttpServletResponse.SC_BAD_REQUEST, "Only POST/GET")); still >100 char http://codereview.appspot.com/1032045/diff/6001/7004 File java/common/src/test/java/org/apache/shindig/common/util/JsonConversionUtilTest.java (right): http://codereview.appspot.com/1032045/diff/6001/7004#newcode132 java/common/src/test/java/org/apache/shindig/common/util/JsonConversionUtilTest.java:132: } nit: 1-space off indent http://codereview.appspot.com/1032045/diff/6001/7005 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/RpcServlet.java (right): http://codereview.appspot.com/1032045/diff/6001/7005#newcode65 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/RpcServlet.java:65: HttpUtil.isJSONP(request); is this just for the side-effect of param validation? http://codereview.appspot.com/1032045/show
